From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
oprofile-list <oprofile-list@lists.sourceforge.net>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH 18/18] oprofile: rename variables in add_ibs_begin()
Date: Wed, 7 Jan 2009 23:17:35 +0100 [thread overview]
Message-ID: <1231366655-17837-19-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1231366655-17837-1-git-send-email-robert.richter@amd.com>
This unifies usage of variable names within oprofile.
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
drivers/oprofile/buffer_sync.c | 26 +++++++++++++-------------
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index bf8fcc7..21fd249 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -325,36 +325,36 @@ static void add_trace_begin(void)
*/
static void add_ibs_begin(int cpu, int code, struct mm_struct *mm)
{
- unsigned long rip;
+ unsigned long pc;
int i, count;
- unsigned long ibs_cookie = 0;
+ unsigned long cookie = 0;
off_t offset;
struct op_sample *sample;
sample = op_cpu_buffer_read_entry(cpu);
if (!sample)
return;
- rip = sample->eip;
+ pc = sample->eip;
#ifdef __LP64__
- rip += sample->event << 32;
+ pc += sample->event << 32;
#endif
if (mm) {
- ibs_cookie = lookup_dcookie(mm, rip, &offset);
+ cookie = lookup_dcookie(mm, pc, &offset);
- if (ibs_cookie == NO_COOKIE)
- offset = rip;
- if (ibs_cookie == INVALID_COOKIE) {
+ if (cookie == NO_COOKIE)
+ offset = pc;
+ if (cookie == INVALID_COOKIE) {
atomic_inc(&oprofile_stats.sample_lost_no_mapping);
- offset = rip;
+ offset = pc;
}
- if (ibs_cookie != last_cookie) {
- add_cookie_switch(ibs_cookie);
- last_cookie = ibs_cookie;
+ if (cookie != last_cookie) {
+ add_cookie_switch(cookie);
+ last_cookie = cookie;
}
} else
- offset = rip;
+ offset = pc;
add_event_entry(ESCAPE_CODE);
add_event_entry(code);
--
1.6.0.1
next prev parent reply other threads:[~2009-01-07 22:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 22:17 [0/18] oprofile: fixes and cleanup patches Robert Richter
2009-01-07 22:17 ` [PATCH 01/18] oprofile: rename kernel-wide identifiers Robert Richter
2009-01-13 17:53 ` Maynard Johnson
2009-01-14 14:21 ` Robert Richter
2009-01-07 22:17 ` [PATCH 02/18] oprofile: rename cpu buffer functions Robert Richter
2009-01-13 18:02 ` Maynard Johnson
2009-01-07 22:17 ` [PATCH 03/18] oprofile: remove ring buffer inline functions in cpu_buffer.h Robert Richter
2009-01-07 22:17 ` [PATCH 04/18] x86/oprofile: fix pci_dev use count for AMD northbridge devices Robert Richter
2009-01-07 22:17 ` [PATCH 05/18] oprofile: reordering some code in cpu_buffer.c Robert Richter
2009-01-07 22:17 ` [PATCH 06/18] oprofile: add inline function __oprofile_add_ext_sample() Robert Richter
2009-01-07 22:17 ` [PATCH 07/18] oprofile: simplify add_sample() Robert Richter
2009-01-07 22:17 ` [PATCH 08/18] oprofile: simplify sync_buffer() Robert Richter
2009-01-07 22:17 ` [PATCH 09/18] oprofile: simplify oprofile_begin_trace() Robert Richter
2009-01-07 22:17 ` [PATCH 10/18] oprofile: simplify add_sample() in cpu_buffer.c Robert Richter
2009-01-07 22:17 ` [PATCH 11/18] oprofile: simplify add_ibs_begin() Robert Richter
2009-01-07 22:17 ` [PATCH 12/18] oprofile: remove unused components in struct oprofile_cpu_buffer Robert Richter
2009-01-07 22:17 ` [PATCH 13/18] oprofile: remove unused ibs macro Robert Richter
2009-01-07 22:17 ` [PATCH 14/18] oprofile: remove backtrace code for ibs Robert Richter
2009-01-07 22:17 ` [PATCH 15/18] oprofile: making add_sample_entry() inline Robert Richter
2009-01-07 22:17 ` [PATCH 16/18] oprofile: rename variable ibs_allowed to has_ibs in op_model_amd.c Robert Richter
2009-01-07 22:17 ` [PATCH 17/18] oprofile: rename add_sample() in cpu_buffer.c Robert Richter
2009-01-07 22:17 ` Robert Richter [this message]
2009-01-08 12:10 ` [0/18] oprofile: fixes and cleanup patches Ingo Molnar
2009-01-13 19:51 ` Maynard Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231366655-17837-19-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome