From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] V4L: stk11xx, use ARRAY_SIZE in another 2 cases
Date: Tue, 28 Aug 2007 04:17:15 -0400 [thread overview]
Message-ID: <12315207221202319057@pripojeni.net> (raw)
stk11xx, use ARRAY_SIZE in another 2 cases
There were 2 places with constant in for loop. Use ARRARY_SIZE instead to
allow easy update of the tables.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit addcd116df57eaca525a1c827efdd5bf3e61b7b5
tree a4ee11673dfdbaabe1500cd9e4301bd535177bfa
parent 926af968884e1e153ad2f91892ff71ec33005d22
author Jiri Slaby <jirislaby@gmail.com> Tue, 28 Aug 2007 09:53:55 +0200
committer Jiri Slaby <jirislaby@gmail.com> Tue, 28 Aug 2007 09:53:55 +0200
drivers/media/video/stk1125.c | 2 +-
drivers/media/video/stk1135.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/stk1125.c b/drivers/media/video/stk1125.c
index ed3cc58..2429225 100644
--- a/drivers/media/video/stk1125.c
+++ b/drivers/media/video/stk1125.c
@@ -80,7 +80,7 @@ static int stk1125_load_microcode(struct stk11xx *dev)
break;
}
- for (i = 0; i < 59; i++) {
+ for (i = 0; i < ARRAY_SIZE(values_1_204); i++) {
stk11xx_read_dummy(dev, 0x02ff);
stk11xx_write_reg(dev, 0x02ff, 0x00);
diff --git a/drivers/media/video/stk1135.c b/drivers/media/video/stk1135.c
index c6e0361..9acd951 100644
--- a/drivers/media/video/stk1135.c
+++ b/drivers/media/video/stk1135.c
@@ -53,7 +53,7 @@ static int stk1135_load_microcode(struct stk11xx *dev)
0xe4, 0x09, 0xc8, 0x08, 0x08, 0x10, 0x14
};
- for (i = 0; i < 117; i++) {
+ for (i = 0; i < ARRAY_SIZE(values_204); i++) {
stk11xx_read_dummy(dev, 0x02ff);
stk11xx_write_reg(dev, 0x02ff, 0x00);
next reply other threads:[~2007-08-28 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 8:17 Jiri Slaby [this message]
2007-08-28 8:17 ` [PATCH 2/3] V4L: stk11xx, use retval from stk11xx_check_device Jiri Slaby
2007-08-28 8:18 ` [PATCH 3/3] V4L: stk11xx, add static to tables Jiri Slaby
2007-08-29 10:42 ` Satyam Sharma
2007-08-31 18:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12315207221202319057@pripojeni.net \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®