From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] V4L: stk11xx, use retval from stk11xx_check_device
Date: Tue, 28 Aug 2007 04:17:54 -0400 [thread overview]
Message-ID: <54324564250413328@pripojeni.net> (raw)
In-Reply-To: <12315207221202319057@pripojeni.net>
stk11xx, use retval from stk11xx_check_device
stk11xx_check_device returns 0 for success of non-inited device, 1 for
success of inited device and negative for error cases. bubble the negative
value to the caller.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit 95de679efc8c9fbd13121f3fbe4144196a66f387
tree bdc82d59c4ea9ec96abdde81209cb319d71192b6
parent addcd116df57eaca525a1c827efdd5bf3e61b7b5
author Jiri Slaby <jirislaby@gmail.com> Tue, 28 Aug 2007 09:55:20 +0200
committer Jiri Slaby <jirislaby@gmail.com> Tue, 28 Aug 2007 09:55:20 +0200
drivers/media/video/stk1125.c | 2 +-
drivers/media/video/stk1135.c | 2 +-
drivers/media/video/stkdcnew.c | 3 +--
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/stk1125.c b/drivers/media/video/stk1125.c
index 2429225..f12030d 100644
--- a/drivers/media/video/stk1125.c
+++ b/drivers/media/video/stk1125.c
@@ -91,7 +91,7 @@ static int stk1125_load_microcode(struct stk11xx *dev)
retok = stk11xx_check_device(dev, 500);
if (retok != 1) {
dev_err(&dev->udev->dev, "load microcode fail\n");
- return -EIO;
+ return retok < 0 ? retok : -EIO;
}
stk11xx_write_reg(dev, 0x02ff, 0x00);
diff --git a/drivers/media/video/stk1135.c b/drivers/media/video/stk1135.c
index 9acd951..cba95e0 100644
--- a/drivers/media/video/stk1135.c
+++ b/drivers/media/video/stk1135.c
@@ -64,7 +64,7 @@ static int stk1135_load_microcode(struct stk11xx *dev)
retok = stk11xx_check_device(dev, 500);
if (retok != 1) {
dev_err(&dev->udev->dev, "load microcode failed\n");
- return -EIO;
+ return retok < 0 ? retok : -EIO;
}
stk11xx_write_reg(dev, 0x02ff, 0x00);
diff --git a/drivers/media/video/stkdcnew.c b/drivers/media/video/stkdcnew.c
index 52513e2..00176f2 100644
--- a/drivers/media/video/stkdcnew.c
+++ b/drivers/media/video/stkdcnew.c
@@ -102,10 +102,9 @@ static int stkdcnew_load_microcode(struct stk11xx *dev)
stk11xx_write_reg(dev, 0x0200, 0x01);
retok = stk11xx_check_device(dev, 500);
-
if (retok != 1) {
dev_err(&dev->udev->dev, "load microcode fail!\n");
- return -EIO;
+ return retok < 0 ? retok : -EIO;
}
stk11xx_write_reg(dev, 0x02ff, 0x00);
next prev parent reply other threads:[~2007-08-28 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 8:17 [PATCH 1/3] V4L: stk11xx, use ARRAY_SIZE in another 2 cases Jiri Slaby
2007-08-28 8:17 ` Jiri Slaby [this message]
2007-08-28 8:18 ` [PATCH 3/3] V4L: stk11xx, add static to tables Jiri Slaby
2007-08-29 10:42 ` Satyam Sharma
2007-08-31 18:40 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54324564250413328@pripojeni.net \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®