* [PATCH] regulator: move bq24022 init back to module_init instead of subsys_initcall
@ 2009-01-18 13:32 Philipp Zabel
2009-01-18 13:50 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2009-01-18 13:32 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, Philipp Zabel
This workaround was needed when regulator/ was not linked before both
power/ and usb/otg/ in drivers/Makefile. Now that it is even linked
before mfd/, this patch makes sure that bq24022 isn't probed before the
GPIO expander is set up.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
drivers/regulator/bq24022.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/bq24022.c b/drivers/regulator/bq24022.c
index ebae7c0..21682d5 100644
--- a/drivers/regulator/bq24022.c
+++ b/drivers/regulator/bq24022.c
@@ -165,11 +165,7 @@ static void __exit bq24022_exit(void)
platform_driver_unregister(&bq24022_driver);
}
-/*
- * make sure this is probed before gpio_vbus and pda_power,
- * but after asic3 or other GPIO expander drivers.
- */
-subsys_initcall(bq24022_init);
+module_init(bq24022_init);
module_exit(bq24022_exit);
MODULE_AUTHOR("Philipp Zabel");
--
1.5.6.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: move bq24022 init back to module_init instead of subsys_initcall
2009-01-18 13:32 [PATCH] regulator: move bq24022 init back to module_init instead of subsys_initcall Philipp Zabel
@ 2009-01-18 13:50 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2009-01-18 13:50 UTC (permalink / raw)
To: Philipp Zabel; +Cc: linux-kernel, Mark Brown
On Sun, 2009-01-18 at 14:32 +0100, Philipp Zabel wrote:
> This workaround was needed when regulator/ was not linked before both
> power/ and usb/otg/ in drivers/Makefile. Now that it is even linked
> before mfd/, this patch makes sure that bq24022 isn't probed before the
> GPIO expander is set up.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> ---
> drivers/regulator/bq24022.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-18 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-18 13:32 [PATCH] regulator: move bq24022 init back to module_init instead of subsys_initcall Philipp Zabel
2009-01-18 13:50 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®