Re: [PATCH 1/4] [Linux/SCSI]: Change RECEIVE_CREDENTIAL to VLC_SA_RECEIVE_CREDENTIAL

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Thu, 2009-01-29 at 13:46 +0200, Boaz Harrosh wrote:
> Nicholas A. Bellinger wrote:
> > Hi James,
> > 
> > Let me know if you need a fresh respin of this patch..  According to
> > spc4r17 section D.3.5, VLC_SA_RECEIVE_CREDENTIAL is the only
> > VARIABLE_LENGTH_CMD defined Service ACtion..
> > 
> > --nab
> 
> Not accurate. See file include/scsi/osd_protocol.h in the scsi-misc
> git-tree master branch. The complete OSD command set is VARIABLE_LENGTH_CMD
> based. There must be others as well
> 

Ok, what I meant was:

>From searching spc4r17, VLC_SA_RECEIVE_CREDENTIAL (0x1800) is the only
SPC-4 defined VARIABLE_LENGTH_CMD defined Service Action in Table D.8.
>From SPC-4, the range 0x1800 -> 0x1FFF is reserved for SPC-4 defined
VARIABLE_LENGTH_CMD SAs.  

I see that OSD SAs for VARIABLE_LENGTH_CMD opcode are defined in range
0x8800 -> 0x8FFF, so does not it make sense to add the single VLC_SA_*
prefixed define above for range 0x1800 -> 0x1FFF in
include/scsi/scsi.h..?

Many thanks for your most valuable of time,

--nab


> Boaz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>