mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: davej@codemonkey.org.uk
Cc: mark.langsdorf@amd.com, cpufreq@vger.kernel.org,
	venkatesh.pallipadi@intel.com, linux-kernel@vger.kernel.org,
	Thomas Renninger <trenn@suse.de>
Subject: [PATCH 6/7] CPUFREQ: powernow-k8: Only print error message once, not per core.
Date: Tue,  3 Feb 2009 17:46:45 +0100	[thread overview]
Message-ID: <1233679606-1971-7-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1233679606-1971-1-git-send-email-trenn@suse.de>

This is the typical message you get if you plug in a CPU
which is newer than your BIOS. It's annoying seeing this
message for each core.

Signed-off-by: Thomas Renninger <trenn@suse.de>
---
 arch/x86/kernel/cpu/cpufreq/powernow-k8.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
index 9accffb..9e312c5 100644
--- a/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
+++ b/arch/x86/kernel/cpu/cpufreq/powernow-k8.c
@@ -743,7 +743,7 @@ static int find_psb_table(struct powernow_k8_data *data)
 	 * BIOS and Kernel Developer's Guide, which is available on
 	 * www.amd.com
 	 */
-	printk(KERN_ERR PFX "BIOS error - no PSB or ACPI _PSS objects\n");
+	printk(KERN_ERR FW_BUG PFX "No PSB or ACPI _PSS objects\n");
 	return -ENODEV;
 }
 
@@ -1154,11 +1154,11 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
 		 * an UP version, and is deprecated by AMD.
 		 */
 		if (num_online_cpus() != 1) {
-			printk(KERN_ERR FW_BUG PFX "Your BIOS does not provide"
-			       " ACPI _PSS objects in a way that Linux "
-			       "understands. Please report this to the Linux "
-			       "ACPI maintainers and complain to your BIOS "
-			       "vendor.\n");
+			WARN_ONCE(1, KERN_ERR FW_BUG PFX "Your BIOS does not "
+				  "provide ACPI _PSS objects in a way that "
+				  "Linux understands. Please report this to "
+				  "the Linux ACPI maintainers and complain to "
+				  "your BIOS vendor.\n");
 			goto err_out;
 		}
 		if (pol->cpu != 0) {
-- 
1.6.0.2


  parent reply	other threads:[~2009-02-03 16:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-03 16:46 CPUFREQ: Ondemand and powernow-k8 enhancements/fixes/cleanups Thomas Renninger
2009-02-03 16:46 ` [PATCH 1/7] CPUFREQ: Introduce /sys/devices/system/cpu/cpu*/cpufreq/cpuinfo_transition_latency Thomas Renninger
2009-02-03 16:46 ` [PATCH 2/7] CPUFREQ: ondemand/conservative: deprecate sampling_rate{min,max} Thomas Renninger
2009-02-04  5:03   ` Andrew Morton
2009-02-03 16:46 ` [PATCH 3/7] CPUFREQ: ondemand/conservative: sanitize sampling_rate restrictions Thomas Renninger
2009-02-04  5:07   ` Andrew Morton
2009-02-04 10:07     ` Thomas Renninger
2009-02-03 16:46 ` [PATCH 4/7] CPUFREQ: powernow-k8: Get transition latency from ACPI _PSS table Thomas Renninger
2009-02-08 18:35   ` Robert Hancock
2009-02-03 16:46 ` [PATCH 5/7] CPUFREQ: powernow-k8: Always compile powernow-k8 driver with ACPI support Thomas Renninger
2009-02-03 16:46 ` Thomas Renninger [this message]
2009-02-04  5:09   ` [PATCH 6/7] CPUFREQ: powernow-k8: Only print error message once, not per core Andrew Morton
2009-02-04  9:59     ` Thomas Renninger
2009-02-03 16:46 ` [PATCH 7/7] ACPI: cpufreq: Remove deprecated /proc/acpi/processor/../performance proc entries Thomas Renninger
2009-02-04  5:13   ` Len Brown
2009-02-03 16:48 ` CPUFREQ: Ondemand and powernow-k8 enhancements/fixes/cleanups Dave Jones
2009-02-03 21:21 ` Dave Jones
2009-02-03 23:29   ` Thomas Renninger
2009-02-03 23:44     ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233679606-1971-7-git-send-email-trenn@suse.de \
    --to=trenn@suse.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®