From: Alberto Bertogli <albertito@blitiri.com.ar>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org,
Alberto Bertogli <albertito@blitiri.com.ar>
Subject: [PATCH] Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq()
Date: Wed, 4 Feb 2009 16:45:02 -0200 [thread overview]
Message-ID: <1233773102-12903-1-git-send-email-albertito@blitiri.com.ar> (raw)
In-Reply-To: <20090203085111.GT30821@kernel.dk>
On Tue, Feb 03 2009, Andrew Morton wrote:
> The comment is wrong - this was a sparc requirement, long since removed.
So remove both the comment and the inline requirement, going back to the
inline hint.
Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
---
So I came up with this, but I'm not sure if it's better than just avoid the
inline and placing them somewhere else. If you want me to write a different
patch, let me know.
Thanks a lot,
Alberto
include/linux/bio.h | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 713ec6e..20bcc51 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -442,10 +442,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly;
/*
* remember never ever reenable interrupts between a bvec_kmap_irq and
* bvec_kunmap_irq!
- *
- * This function MUST be inlined - it plays with the CPU interrupt flags.
*/
-static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
+static inline char *bvec_kmap_irq(struct bio_vec *bvec,
unsigned long *flags)
{
unsigned long addr;
@@ -462,7 +460,7 @@ static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
return (char *) addr + bvec->bv_offset;
}
-static __always_inline void bvec_kunmap_irq(char *buffer,
+static inline void bvec_kunmap_irq(char *buffer,
unsigned long *flags)
{
unsigned long ptr = (unsigned long) buffer & PAGE_MASK;
--
1.6.1.1.363.g2a3bd
next prev parent reply other threads:[~2009-02-04 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 0:07 [PATCH 1/2] Fix misleading comment in bio.h Alberto Bertogli
2009-02-02 0:07 ` [PATCH 2/2] bio.h: If they MUST be inlined, then use __always_inline Alberto Bertogli
2009-02-02 11:41 ` Jens Axboe
2009-02-03 8:51 ` Andrew Morton
2009-02-03 8:51 ` Jens Axboe
2009-02-04 18:45 ` Alberto Bertogli [this message]
2009-02-04 18:49 ` [PATCH] Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq() Alberto Bertogli
2009-10-31 21:21 Alberto Bertogli
2009-11-02 10:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233773102-12903-1-git-send-email-albertito@blitiri.com.ar \
--to=albertito@blitiri.com.ar \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®