From: Andrew Morton <akpm@linux-foundation.org>
To: Alberto Bertogli <albertito@blitiri.com.ar>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] bio.h: If they MUST be inlined, then use __always_inline
Date: Tue, 3 Feb 2009 00:51:41 -0800 [thread overview]
Message-ID: <20090203005141.0214d47b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1233533251-30240-2-git-send-email-albertito@blitiri.com.ar>
On Sun, 1 Feb 2009 22:07:31 -0200 Alberto Bertogli <albertito@blitiri.com.ar> wrote:
> bvec_kmap_irq() and bvec_kunmap_irq() comments say they MUST be inlined,
> so mark them as __always_inline.
>
> Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
> ---
> include/linux/bio.h | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 0c8e3fb..713ec6e 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -445,7 +445,8 @@ extern struct biovec_slab bvec_slabs[BIOVEC_NR_POOLS] __read_mostly;
> *
> * This function MUST be inlined - it plays with the CPU interrupt flags.
> */
> -static inline char *bvec_kmap_irq(struct bio_vec *bvec, unsigned long *flags)
> +static __always_inline char *bvec_kmap_irq(struct bio_vec *bvec,
> + unsigned long *flags)
The comment is wrong - this was a sparc requirement, long since removed.
next prev parent reply other threads:[~2009-02-03 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 0:07 [PATCH 1/2] Fix misleading comment in bio.h Alberto Bertogli
2009-02-02 0:07 ` [PATCH 2/2] bio.h: If they MUST be inlined, then use __always_inline Alberto Bertogli
2009-02-02 11:41 ` Jens Axboe
2009-02-03 8:51 ` Andrew Morton [this message]
2009-02-03 8:51 ` Jens Axboe
2009-02-04 18:45 ` [PATCH] Do not __always_inline bvec_kmap_irq() and bvec_kunmap_irq() Alberto Bertogli
2009-02-04 18:49 ` Alberto Bertogli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203005141.0214d47b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=albertito@blitiri.com.ar \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome