[PATCH] net: replace commatas with semicolons

[PATCH] net: replace commatas with semicolons

[Thomas Gleixner]

Impact: syntax fix

Interestingly enough this compiles w/o any complaints:

	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 net/ipv4/proc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/net/ipv4/proc.c
===================================================================
--- linux-2.6.orig/net/ipv4/proc.c
+++ linux-2.6/net/ipv4/proc.c
@@ -54,8 +54,8 @@ static int sockstat_seq_show(struct seq_
 	int orphans, sockets;
 
 	local_bh_disable();
-	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
-	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),
+	orphans = percpu_counter_sum_positive(&tcp_orphan_count);
+	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated);
 	local_bh_enable();
 
 	socket_seq_show(seq);

Re: [PATCH] net: replace commatas with semicolons

[Peter Zijlstra]

On Fri, 2009-02-13 at 22:46 +0100, Thomas Gleixner wrote:
> Impact: syntax fix
> 
> Interestingly enough this compiles w/o any complaints:
> 
> 	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
> 	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),

Yep, the wonders of the , operator. Look her up the next time you're
reading the C specs and marvel :-)

Re: [PATCH] net: replace commatas with semicolons

[David Miller]

From: Thomas Gleixner <tglx@linutronix.de>
Date: Fri, 13 Feb 2009 22:46:21 +0100 (CET)

> Impact: syntax fix
> 
> Interestingly enough this compiles w/o any complaints:
> 
> 	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
> 	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Applied, please CC: netdev on future patches so that they
get properly tracked at:

	http://patchwork.ozlabs.org/project/netdev/list/

Thank you.

> ---
>  net/ipv4/proc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6/net/ipv4/proc.c
> ===================================================================
> --- linux-2.6.orig/net/ipv4/proc.c
> +++ linux-2.6/net/ipv4/proc.c
> @@ -54,8 +54,8 @@ static int sockstat_seq_show(struct seq_
>  	int orphans, sockets;
>  
>  	local_bh_disable();
> -	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
> -	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),
> +	orphans = percpu_counter_sum_positive(&tcp_orphan_count);
> +	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated);
>  	local_bh_enable();
>  
>  	socket_seq_show(seq);

Re: [PATCH] net: replace commatas with semicolons

[David Miller]

From: Peter Zijlstra <peterz@infradead.org>
Date: Fri, 13 Feb 2009 23:59:43 +0100

> On Fri, 2009-02-13 at 22:46 +0100, Thomas Gleixner wrote:
> > Impact: syntax fix
> > 
> > Interestingly enough this compiles w/o any complaints:
> > 
> > 	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
> > 	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),
> 
> Yep, the wonders of the , operator. Look her up the next time you're
> reading the C specs and marvel :-)

"," has nothing on "sizeof(unsigned (long))" which is accepted
by C compilers too. :-)

Re: [PATCH] net: replace commatas with semicolons

[Johannes Weiner]

On Fri, Feb 13, 2009 at 10:46:21PM +0100, Thomas Gleixner wrote:
> Impact: syntax fix
> 
> Interestingly enough this compiles w/o any complaints:
> 
> 	orphans = percpu_counter_sum_positive(&tcp_orphan_count),
> 	sockets = percpu_counter_sum_positive(&tcp_sockets_allocated),

C's equivalent of Common Lisps PROGN.  Try:

	a = (foo(), 2);

it's magic!

	Hannes