mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] kmemleak: Fix section mismatch in kmemleak.c
Date: Wed, 18 Feb 2009 10:06:03 +0000	[thread overview]
Message-ID: <1234951563.20374.43.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <b9df5fa10902131942q4670aa16s6c190fd99384943e@mail.gmail.com>

On Sat, 2009-02-14 at 09:42 +0600, Rakib Mullick wrote:
> Impact: Section mismatch
> 
> The function kmemleak_alloc() is called from kernel allocators.
> kmemleak_alloc() calls log_early() but being log_early() marked as
> __init it causes following section mismatches. Being called from
> kernel allocators, kmemleak_allock() will be called after freeing up
> the init memory and log_early() will also called. So, unmarking __init
> from log_early() fixes the warning. If anything else please notice.

Thanks for the patch. There's nothing dangerous as kmemleak takes care
of not using the __init functions after it was initialised but I
couldn't find a way to free these functions/data and also avoid the
warning.

Anyway, that's fine as an interim patch but I think I'll just allocate
some pages dynamically for the early logging buffer so that we can free
them once initialised. I'll update the kmemleak branch sometime this
week.

Thanks.

-- 
Catalin


      reply	other threads:[~2009-02-18 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  3:42 Rakib Mullick
2009-02-18 10:06 ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234951563.20374.43.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rakib.mullick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®