mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rakib Mullick <rakib.mullick@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: [PATCH -mm] kmemleak: Fix section mismatch in kmemleak.c
Date: Sat, 14 Feb 2009 09:42:38 +0600	[thread overview]
Message-ID: <b9df5fa10902131942q4670aa16s6c190fd99384943e@mail.gmail.com> (raw)

 Impact: Section mismatch

The function kmemleak_alloc() is called from kernel allocators.
kmemleak_alloc() calls log_early() but being log_early() marked as
__init it causes following section mismatches. Being called from
kernel allocators, kmemleak_allock() will be called after freeing up
the init memory and log_early() will also called. So, unmarking __init
from log_early() fixes the warning. If anything else please notice.

  LD      mm/built-in.o
WARNING: mm/built-in.o(.text+0x4f371): Section mismatch in reference
from the function kmemleak_alloc() to the function
.init.text:log_early()
The function kmemleak_alloc() references
the function __init log_early().
This is often because kmemleak_alloc lacks a __init
annotation or the annotation of log_early is wrong.

WARNING: mm/built-in.o(.text+0x4f470): Section mismatch in reference
from the function kmemleak_free() to the function
.init.text:log_early()
The function kmemleak_free() references
the function __init log_early().
This is often because kmemleak_free lacks a __init
annotation or the annotation of log_early is wrong.

WARNING: mm/built-in.o(.text+0x4f56f): Section mismatch in reference
from the function kmemleak_not_leak() to the function
.init.text:log_early()
The function kmemleak_not_leak() references
the function __init log_early().
This is often because kmemleak_not_leak lacks a __init
annotation or the annotation of log_early is wrong.

WARNING: mm/built-in.o(.text+0x4f66e): Section mismatch in reference
from the function kmemleak_ignore() to the function
.init.text:log_early()
The function kmemleak_ignore() references
the function __init log_early().
This is often because kmemleak_ignore lacks a __init
annotation or the annotation of log_early is wrong.

WARNING: mm/built-in.o(.text+0x4f786): Section mismatch in reference
from the function kmemleak_scan_area() to the function
.init.text:log_early()
The function kmemleak_scan_area() references
the function __init log_early().
This is often because kmemleak_scan_area lacks a __init
annotation or the annotation of log_early is wrong.

WARNING: mm/built-in.o(.text+0x4f885): Section mismatch in reference
from the function kmemleak_no_scan() to the function
.init.text:log_early()
The function kmemleak_no_scan() references
the function __init log_early().
This is often because kmemleak_no_scan lacks a __init
annotation or the annotation of log_early is wrong.

Thanks.

----
Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

--- linus/mm/kmemleak.c	2009-02-13 11:23:55.000000000 +0600
+++ rakib/mm/kmemleak.c	2009-02-13 23:05:45.000000000 +0600
@@ -230,8 +230,8 @@ struct early_log {
 };

 /* early logging buffer and current position */
-static struct early_log __initdata early_log[200];
-static int __initdata crt_early_log;
+static struct early_log early_log[200];
+static int crt_early_log;

 static void kmemleak_disable(void);

@@ -682,7 +682,7 @@ static void object_no_scan(unsigned long
  * Log an early kmemleak_* call to the early_log buffer. These calls will be
  * processed later once kmemleak is fully initialized.
  */
-static void __init log_early(int op_type, const void *ptr, size_t size,
+static void log_early(int op_type, const void *ptr, size_t size,
 			     int min_count,
 			     unsigned long offset, size_t length)
 {

             reply	other threads:[~2009-02-14  3:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  3:42 Rakib Mullick [this message]
2009-02-18 10:06 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10902131942q4670aa16s6c190fd99384943e@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®