* [RFC PATCH] kernel: add -D__CHECK_ENDIAN__ by default
@ 2009-02-18 21:33 Harvey Harrison
2009-02-19 18:57 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2009-02-18 21:33 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton; +Cc: linux-arch, LKML, Al Viro
The noise level with endian checking is getting to the point where
having this enabled by default wouldn't be too bad. If this were to
go in for the 2.6.30 devel cycle it may motivate the last sections that
are still particularly noisy (sound/, drivers/scsi/ come to mind)
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 96628d0..4d4e400 100644
--- a/Makefile
+++ b/Makefile
@@ -326,7 +326,7 @@ PERL = perl
CHECK = sparse
CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
- -Wbitwise -Wno-return-void $(CF)
+ -D__CHECK_ENDIAN__ -Wbitwise -Wno-return-void $(CF)
MODFLAGS = -DMODULE
CFLAGS_MODULE = $(MODFLAGS)
AFLAGS_MODULE = $(MODFLAGS)
--
1.6.2.rc1.175.g96b8a
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] kernel: add -D__CHECK_ENDIAN__ by default
2009-02-18 21:33 [RFC PATCH] kernel: add -D__CHECK_ENDIAN__ by default Harvey Harrison
@ 2009-02-19 18:57 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2009-02-19 18:57 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Linus Torvalds, Andrew Morton, linux-arch, LKML, Al Viro
On Wed, Feb 18, 2009 at 01:33:01PM -0800, Harvey Harrison wrote:
> The noise level with endian checking is getting to the point where
> having this enabled by default wouldn't be too bad. If this were to
> go in for the 2.6.30 devel cycle it may motivate the last sections that
> are still particularly noisy (sound/, drivers/scsi/ come to mind)
In which case you should juse kill the CHECK_ENDIAN ifdef and make
the checking versions the default. Also Documentation/sparse.txt
needs some updates for this change.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-19 18:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-18 21:33 [RFC PATCH] kernel: add -D__CHECK_ENDIAN__ by default Harvey Harrison
2009-02-19 18:57 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome