* [PATCH] driver core: remove polling for driver_probe_done(v5)
@ 2009-02-21 8:45 tom.leiming
0 siblings, 0 replies; only message in thread
From: tom.leiming @ 2009-02-21 8:45 UTC (permalink / raw)
To: kay.sievers, greg; +Cc: cornelia.huck, arjan, linux-kernel, Ming Lei
From: Ming Lei <tom.leiming@gmail.com>
This patch removes 100ms polling for driver_probe_done in
wait_for_device_probe(), and uses wait_event() instead.
Removing polling in fs initialization may lead to
a faster boot.
This patch also changes the return type of wait_for_device_done()
from int to void.
This patch is against Arjan's patch in linux-next tree.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Arjan van de Ven <arjan@linux.intel.com>
---
drivers/base/dd.c | 8 ++------
include/linux/device.h | 2 +-
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 62a31b9..f17c326 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -172,16 +172,12 @@ int driver_probe_done(void)
/**
* wait_for_device_probe
* Wait for device probing to be completed.
- *
- * Note: this function polls at 100 msec intervals.
*/
-int wait_for_device_probe(void)
+void wait_for_device_probe(void)
{
/* wait for the known devices to complete their probing */
- while (driver_probe_done() != 0)
- msleep(100);
+ wait_event(probe_waitqueue, atomic_read(&probe_count) == 0);
async_synchronize_full();
- return 0;
}
/**
diff --git a/include/linux/device.h b/include/linux/device.h
index f6d6270..723e7b2 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -148,7 +148,7 @@ extern void put_driver(struct device_driver *drv);
extern struct device_driver *driver_find(const char *name,
struct bus_type *bus);
extern int driver_probe_done(void);
-extern int wait_for_device_probe(void);
+extern void wait_for_device_probe(void);
/* sysfs interface for exporting driver attributes */
--
1.6.0.GIT
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-02-21 8:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-21 8:45 [PATCH] driver core: remove polling for driver_probe_done(v5) tom.leiming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®