* [PATCH 1/1] Char: mxser, remove tty_port_tty_get from mxser_check_modem_status
@ 2009-03-16 11:04 Jiri Slaby
0 siblings, 0 replies; only message in thread
From: Jiri Slaby @ 2009-03-16 11:04 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Jiri Slaby, Alan Cox
mxser_check_modem_status is called with tty parameter, so the
reference should be increased by callers already -- for ioctl
syscall it is held whole time gap since open to close, for
interrupt, the reference count is increased in the irq handler.
There is no tty_kref_put in that function, so this also fixes
a refcounting bug.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
---
drivers/char/mxser.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index 402c9f2..a420e8d 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty,
wake_up_interruptible(&port->port.open_wait);
}
- tty = tty_port_tty_get(&port->port);
if (port->port.flags & ASYNC_CTS_FLOW) {
if (tty->hw_stopped) {
if (status & UART_MSR_CTS) {
--
1.6.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-16 11:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-16 11:04 [PATCH 1/1] Char: mxser, remove tty_port_tty_get from mxser_check_modem_status Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome