From: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
To: mingo@elte.hu, linux-kernel@vger.kernel.org
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Subject: [PATCH 3/3] trace: fix four sparse warnings
Date: Sun, 22 Mar 2009 19:11:11 +0200 [thread overview]
Message-ID: <1237741871-5827-4-git-send-email-dmitri.vorobiev@movial.com> (raw)
In-Reply-To: <1237741871-5827-3-git-send-email-dmitri.vorobiev@movial.com>
Impact: cleanup.
This patch fixes the following sparse warnings:
kernel/trace/trace.c:385:9: warning: symbol 'trace_seq_to_buffer' was
not declared. Should it be static?
kernel/trace/trace_clock.c:29:13: warning: symbol 'trace_clock_local'
was not declared. Should it be static?
kernel/trace/trace_clock.c:54:13: warning: symbol 'trace_clock' was not
declared. Should it be static?
kernel/trace/trace_clock.c:74:13: warning: symbol 'trace_clock_global'
was not declared. Should it be static?
Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
---
kernel/trace/trace.c | 2 +-
kernel/trace/trace_clock.c | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index e6fac0f..ace685c 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -382,7 +382,7 @@ ssize_t trace_seq_to_user(struct trace_seq *s, char __user *ubuf, size_t cnt)
return cnt;
}
-ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt)
+static ssize_t trace_seq_to_buffer(struct trace_seq *s, void *buf, size_t cnt)
{
int len;
void *ret;
diff --git a/kernel/trace/trace_clock.c b/kernel/trace/trace_clock.c
index 05b176a..b588fd8 100644
--- a/kernel/trace/trace_clock.c
+++ b/kernel/trace/trace_clock.c
@@ -18,6 +18,7 @@
#include <linux/percpu.h>
#include <linux/sched.h>
#include <linux/ktime.h>
+#include <linux/trace_clock.h>
/*
* trace_clock_local(): the simplest and least coherent tracing clock.
--
1.5.6.3
next prev parent reply other threads:[~2009-03-22 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 17:11 [PATCH 0/3] A few cleanups for tip-latest Dmitri Vorobiev
2009-03-22 17:11 ` [PATCH 1/3] Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c Dmitri Vorobiev
2009-03-22 17:11 ` [PATCH 2/3] Fix one sparse warning in kernel/extable.c Dmitri Vorobiev
2009-03-22 17:11 ` Dmitri Vorobiev [this message]
2009-03-22 19:39 ` [tip:tracing/ftrace] tracing: fix four sparse warnings Dmitri Vorobiev
2009-03-25 9:45 ` [tip:tracing/core] tracing, Text Edit Lock: Fix one sparse warning in kernel/extable.c Dmitri Vorobiev
2009-03-22 19:39 ` [tip:x86/cleanups] x86: Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c Dmitri Vorobiev
2009-03-22 17:17 ` [PATCH 0/3] A few cleanups for tip-latest Ingo Molnar
2009-03-22 18:32 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237741871-5827-4-git-send-email-dmitri.vorobiev@movial.com \
--to=dmitri.vorobiev@movial.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®