mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	tglx@linutronix.de, mingo@elte.hu, dmitri.vorobiev@movial.com
Subject: [tip:x86/cleanups] x86: Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c
Date: Sun, 22 Mar 2009 19:39:46 GMT	[thread overview]
Message-ID: <tip-1cc185211a9cb913f6adbe3354e5c256f456ebd2@git.kernel.org> (raw)
In-Reply-To: <1237741871-5827-2-git-send-email-dmitri.vorobiev@movial.com>

Commit-ID:  1cc185211a9cb913f6adbe3354e5c256f456ebd2
Gitweb:     http://git.kernel.org/tip/1cc185211a9cb913f6adbe3354e5c256f456ebd2
Author:     Dmitri Vorobiev <dmitri.vorobiev@movial.com>
AuthorDate: Sun, 22 Mar 2009 19:11:09 +0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 22 Mar 2009 18:15:14 +0100

x86: Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c

Impact: cleanup

This patch fixes the following sparse warnings:

 arch/x86/kernel/apic/io_apic.c:3602:17: warning: symbol 'hpet_msi_type'
 was not declared. Should it be static?

 arch/x86/kernel/apic/io_apic.c:3467:30: warning: Using plain integer as
 NULL pointer

Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
LKML-Reference: <1237741871-5827-2-git-send-email-dmitri.vorobiev@movial.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/kernel/apic/io_apic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 42cdc78..ea97e5e 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3464,7 +3464,7 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
 	int ret, sub_handle;
 	struct msi_desc *msidesc;
 	unsigned int irq_want;
-	struct intel_iommu *iommu = 0;
+	struct intel_iommu *iommu = NULL;
 	int index = 0;
 
 	irq_want = nr_irqs_gsi;
@@ -3599,7 +3599,7 @@ static void hpet_msi_set_affinity(unsigned int irq, const struct cpumask *mask)
 
 #endif /* CONFIG_SMP */
 
-struct irq_chip hpet_msi_type = {
+static struct irq_chip hpet_msi_type = {
 	.name = "HPET_MSI",
 	.unmask = hpet_msi_unmask,
 	.mask = hpet_msi_mask,

  parent reply	other threads:[~2009-03-22 19:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 17:11 [PATCH 0/3] A few cleanups for tip-latest Dmitri Vorobiev
2009-03-22 17:11 ` [PATCH 1/3] Fix a couple of sparse warnings in arch/x86/kernel/apic/io_apic.c Dmitri Vorobiev
2009-03-22 17:11   ` [PATCH 2/3] Fix one sparse warning in kernel/extable.c Dmitri Vorobiev
2009-03-22 17:11     ` [PATCH 3/3] trace: fix four sparse warnings Dmitri Vorobiev
2009-03-22 19:39       ` [tip:tracing/ftrace] tracing: " Dmitri Vorobiev
2009-03-25  9:45     ` [tip:tracing/core] tracing, Text Edit Lock: Fix one sparse warning in kernel/extable.c Dmitri Vorobiev
2009-03-22 19:39   ` Dmitri Vorobiev [this message]
2009-03-22 17:17 ` [PATCH 0/3] A few cleanups for tip-latest Ingo Molnar
2009-03-22 18:32 ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-1cc185211a9cb913f6adbe3354e5c256f456ebd2@git.kernel.org \
    --to=dmitri.vorobiev@movial.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome