* [PATCH] imx_udc: fix leak in imx_ep_alloc_request()
@ 2009-03-23 16:24 Daniel Mack
0 siblings, 0 replies; only message in thread
From: Daniel Mack @ 2009-03-23 16:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Daniel Mack, Mike Lee, Darius Augulis
cppcheck found another leak in drivers/usb/gadget/imx_udc.c
Cc: Mike Lee <eemike@gmail.com>
Cc: Darius Augulis <augulis.darius@gmail.com>
Signed-off-by: Daniel Mack <daniel@caiaq.de>
---
drivers/usb/gadget/imx_udc.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c
index 77c5d0a..3ccd92c 100644
--- a/drivers/usb/gadget/imx_udc.c
+++ b/drivers/usb/gadget/imx_udc.c
@@ -718,9 +718,12 @@ static struct usb_request *imx_ep_alloc_request
{
struct imx_request *req;
+ if (!usb_ep)
+ return NULL;
+
req = kzalloc(sizeof *req, gfp_flags);
- if (!req || !usb_ep)
- return 0;
+ if (!req)
+ return NULL;
INIT_LIST_HEAD(&req->queue);
req->in_use = 0;
--
1.6.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-23 16:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-23 16:24 [PATCH] imx_udc: fix leak in imx_ep_alloc_request() Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®