From: Ian Campbell <Ian.Campbell@citrix.com>
To: linux-kernel@vger.kernel.org
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"Alex.Zeffertt" <Alex.Zeffertt@citrix.com>,
stable@kernel.org
Subject: [PATCH] clockevent: on resume program the next oneshot tick with the next actual event
Date: Wed, 25 Mar 2009 13:40:29 +0000 [thread overview]
Message-ID: <1237988429-26474-1-git-send-email-Ian.Campbell@citrix.com> (raw)
When resuming a Xen domU we were seeing an issue where the timer ticks never
seemed to start up again. This was with CONFIG_NO_HZ=y, the Xen clocksource
has CLOCK_EVT_FEAT_ONESHOT but not CLOCK_EVT_FEAT_PERIODIC.
The issue is that on resume tick_resume_oneshot() tries to program an event for
"now", e.g.
tick_program_event(ktime_get(), 1);
However further down the call chain tick_dev_program_event() then compares that
expiry time with a second call to ktime_get() and discards the event if the
timeout is negative -- which it always will be since some time must have passed
since tick_program_event was called.
Instead of asking for an immediate event on resume, instead ask for the next
actual event.
With this fix I can successfully resume a Xen domain.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Alex.Zeffertt <Alex.Zeffertt@citrix.com>
Cc: stable@kernel.org
---
kernel/time/tick-oneshot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/time/tick-oneshot.c b/kernel/time/tick-oneshot.c
index 2e8de67..8b2c8ed 100644
--- a/kernel/time/tick-oneshot.c
+++ b/kernel/time/tick-oneshot.c
@@ -81,7 +81,7 @@ void tick_resume_oneshot(void)
struct clock_event_device *dev = td->evtdev;
clockevents_set_mode(dev, CLOCK_EVT_MODE_ONESHOT);
- tick_program_event(ktime_get(), 1);
+ tick_program_event(dev->next_event, 1);
}
/**
--
1.5.6.5
next reply other threads:[~2009-03-25 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 13:40 Ian Campbell [this message]
2009-03-25 17:19 ` Jeremy Fitzhardinge
2009-03-25 17:46 ` Ian Campbell
2009-03-25 23:40 ` Jeremy Fitzhardinge
2009-03-26 13:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237988429-26474-1-git-send-email-Ian.Campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Alex.Zeffertt@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®