From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Tom Talpey <tmtalpey@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Yinghai Lu <yinghai@kernel.org>,
David Miller <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
chuck.lever@oracle.com
Subject: Re: [PATCH] nfs: fix nfs_parse_mount_options() double kfree()
Date: Fri, 03 Apr 2009 09:25:48 -0400 [thread overview]
Message-ID: <1238765148.7815.2.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <20090403130724.GA26365@elte.hu>
On Fri, 2009-04-03 at 15:07 +0200, Ingo Molnar wrote:
> * Tom Talpey <tmtalpey@gmail.com> wrote:
>
> > At 03:16 AM 4/3/2009, Ingo Molnar wrote:
> > >
> > >Impact: fix crash
> > >
> > >Yinghai Lu reported the following crash:
> >
> > This has to have been a merge problem, I moved a single kfree()
> > down a few lines in order to use the pointer in a second context.
> > With the moved line, it had been running successfully in Trond's
> > tree and linux-next for several weeks.
>
> Maybe the tree got rebased and that introduced this merge artifact?
No, but the linux-next tree also contained cachefs, which hasn't been
merged yet. Let's keep an eye out when it does...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2009-04-03 13:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86802c440904021512o2405ffa2gcbe057b9f81d5a46@mail.gmail.com>
[not found] ` <20090402222106.GC9239@elte.hu>
2009-04-03 1:19 ` nfs mount fail on linus 20090402 git Yinghai Lu
2009-04-03 5:52 ` Pekka Enberg
2009-04-03 7:08 ` Ingo Molnar
2009-04-03 7:15 ` Yinghai Lu
2009-04-03 7:19 ` Ingo Molnar
2009-04-03 7:16 ` [PATCH] nfs: fix nfs_parse_mount_options() double kfree() Ingo Molnar
2009-04-03 7:23 ` Pekka Enberg
2009-04-03 7:49 ` Yinghai Lu
2009-04-03 12:15 ` Tom Talpey
2009-04-03 13:07 ` Ingo Molnar
2009-04-03 13:25 ` Trond Myklebust [this message]
2009-04-03 18:52 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238765148.7815.2.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=tmtalpey@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome