From: Ingo Molnar <mingo@elte.hu>
To: Tom Talpey <tmtalpey@gmail.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Yinghai Lu <yinghai@kernel.org>,
David Miller <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
chuck.lever@oracle.com
Subject: Re: [PATCH] nfs: fix nfs_parse_mount_options() double kfree()
Date: Fri, 3 Apr 2009 15:07:24 +0200 [thread overview]
Message-ID: <20090403130724.GA26365@elte.hu> (raw)
In-Reply-To: <49d5fe00.86c3f10a.0641.ffffbbdd@mx.google.com>
* Tom Talpey <tmtalpey@gmail.com> wrote:
> At 03:16 AM 4/3/2009, Ingo Molnar wrote:
> >
> >Impact: fix crash
> >
> >Yinghai Lu reported the following crash:
>
> This has to have been a merge problem, I moved a single kfree()
> down a few lines in order to use the pointer in a second context.
> With the moved line, it had been running successfully in Trond's
> tree and linux-next for several weeks.
Maybe the tree got rebased and that introduced this merge artifact?
> Thanks for fixing!
You are welcome!
Ingo
next prev parent reply other threads:[~2009-04-03 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <86802c440904021512o2405ffa2gcbe057b9f81d5a46@mail.gmail.com>
[not found] ` <20090402222106.GC9239@elte.hu>
2009-04-03 1:19 ` nfs mount fail on linus 20090402 git Yinghai Lu
2009-04-03 5:52 ` Pekka Enberg
2009-04-03 7:08 ` Ingo Molnar
2009-04-03 7:15 ` Yinghai Lu
2009-04-03 7:19 ` Ingo Molnar
2009-04-03 7:16 ` [PATCH] nfs: fix nfs_parse_mount_options() double kfree() Ingo Molnar
2009-04-03 7:23 ` Pekka Enberg
2009-04-03 7:49 ` Yinghai Lu
2009-04-03 12:15 ` Tom Talpey
2009-04-03 13:07 ` Ingo Molnar [this message]
2009-04-03 13:25 ` Trond Myklebust
2009-04-03 18:52 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090403130724.GA26365@elte.hu \
--to=mingo@elte.hu \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=tmtalpey@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome