From: Alessio Igor Bogani <abogani@texware.it>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
"Alessio Igor Bogani" <abogani@texware.it>
Subject: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount()
Date: Thu, 23 Apr 2009 15:16:26 +0200 [thread overview]
Message-ID: <1240492586-6654-1-git-send-email-abogani@texware.it> (raw)
Fix ext3_remount()'s "schedule() drops the BKL automatically" assumption,
when ext3_mark_recovery_complete(), which can sleep, does not do that it can
lock up.
Signed-off-by: Alessio Igor Bogani <abogani@texware.it>
---
fs/ext3/super.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index dc905f9..3fa457a 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2561,9 +2561,11 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
* We have to unlock super so that we can wait for
* transactions.
*/
+ unlock_kernel();
unlock_super(sb);
ext3_mark_recovery_complete(sb, es);
lock_super(sb);
+ lock_kernel();
} else {
__le32 ret;
if ((ret = EXT3_HAS_RO_COMPAT_FEATURE(sb,
--
1.6.0.4
next reply other threads:[~2009-04-23 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:16 Alessio Igor Bogani [this message]
2009-04-26 16:39 ` Ingo Molnar
2009-04-27 20:21 ` Alessio Igor Bogani
2009-04-27 20:22 ` [PATCH -tip:kill-the-BKL] " Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240492586-6654-1-git-send-email-abogani@texware.it \
--to=abogani@texware.it \
--cc=a.p.zijlstra@chello.nl \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®