From: Alessio Igor Bogani <abogani@texware.it>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] remove the BKL: remove "BKL auto-drop" assumption from ext3_remount()
Date: Mon, 27 Apr 2009 22:21:39 +0200 [thread overview]
Message-ID: <63a49ef40904271321k47e97c2y5da7f561c7591564@mail.gmail.com> (raw)
In-Reply-To: <20090426163924.GD6236@elte.hu>
Dear Sir Molnar,
2009/4/26 Ingo Molnar <mingo@elte.hu>:
[...]
>> + unlock_kernel();
>> unlock_super(sb);
>> ext3_mark_recovery_complete(sb, es);
>> lock_super(sb);
>> + lock_kernel();
>
> Shouldnt this be a conditional-unlock, so that if the remount moves
> away from under the BKL we dont break in this place?
[...]
Please excuse me I'm only a stupid howler monkey. :-)
Patch with conditional-unlock/lock follow in a second.
Thank you!
Ciao,
Alessio
next prev parent reply other threads:[~2009-04-27 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:16 Alessio Igor Bogani
2009-04-26 16:39 ` Ingo Molnar
2009-04-27 20:21 ` Alessio Igor Bogani [this message]
2009-04-27 20:22 ` [PATCH -tip:kill-the-BKL] " Alessio Igor Bogani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a49ef40904271321k47e97c2y5da7f561c7591564@mail.gmail.com \
--to=abogani@texware.it \
--cc=a.p.zijlstra@chello.nl \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®