* [PATCH 1/1] EDAC: CPC925 MC check fixup
2009-05-05 3:45 [v0 PATCH 0/1] EDAC: CPC925 MC check routine fixup Harry Ciao
@ 2009-05-05 3:45 ` Harry Ciao
0 siblings, 0 replies; 2+ messages in thread
From: Harry Ciao @ 2009-05-05 3:45 UTC (permalink / raw)
To: akpm, bluesmoke-devel; +Cc: norsk5, linux-kernel
Fix an obvious bug in CPC925 Memory Controller's check routine -
edac_mc_handle_ue() should have been called for UECC errors and
edac_mc_handle_ce() for CECC errors.
Signed-off-by: Harry Ciao <qingtao.cao@windriver.com>
---
drivers/edac/cpc925_edac.c | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/cpc925_edac.c b/drivers/edac/cpc925_edac.c
index 2ad6465..8c54196 100644
--- a/drivers/edac/cpc925_edac.c
+++ b/drivers/edac/cpc925_edac.c
@@ -544,17 +544,16 @@ static void cpc925_mc_check(struct mem_ctl_info *mci)
/* Revert column/row addresses into page frame number, etc */
cpc925_mc_get_pfn(mci, mear, &pfn, &offset, &csrow);
- if (apiexcp & UECC_EXCP_DETECTED) {
- cpc925_mc_printk(mci, KERN_INFO, "DRAM UECC Fault\n");
+ if (apiexcp & CECC_EXCP_DETECTED) {
+ cpc925_mc_printk(mci, KERN_INFO, "DRAM CECC Fault\n");
channel = cpc925_mc_find_channel(mci, syndrome);
edac_mc_handle_ce(mci, pfn, offset, syndrome,
csrow, channel, mci->ctl_name);
}
- if (apiexcp & CECC_EXCP_DETECTED) {
- cpc925_mc_printk(mci, KERN_INFO, "DRAM CECC Fault\n");
- edac_mc_handle_ue(mci, pfn, offset,
- csrow, mci->ctl_name);
+ if (apiexcp & UECC_EXCP_DETECTED) {
+ cpc925_mc_printk(mci, KERN_INFO, "DRAM UECC Fault\n");
+ edac_mc_handle_ue(mci, pfn, offset, csrow, mci->ctl_name);
}
cpc925_mc_printk(mci, KERN_INFO, "Dump registers:\n");
--
1.5.6.2
^ permalink raw reply [flat|nested] 2+ messages in thread