From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: [PATCH 3/8] xen: cache cr0 value to avoid trap'n'emulate for read_cr0
Date: Thu, 7 May 2009 13:24:57 -0700 [thread overview]
Message-ID: <1241727902-3176-4-git-send-email-jeremy@goop.org> (raw)
In-Reply-To: <1241727902-3176-1-git-send-email-jeremy@goop.org>
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
stts() is implemented in terms of read_cr0/write_cr0 to update the
state of the TS bit. This happens during context switch, and so
is fairly performance critical. Rather than falling back to
a trap-and-emulate native read_cr0, implement our own by caching
the last-written value from write_cr0 (the TS bit is the only one
we really care about).
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
arch/x86/xen/enlighten.c | 18 +++++++++++++++++-
1 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index cbb31eb..9c6de48 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -656,10 +656,26 @@ static void xen_clts(void)
xen_mc_issue(PARAVIRT_LAZY_CPU);
}
+static DEFINE_PER_CPU(unsigned long, xen_cr0_value);
+
+static unsigned long xen_read_cr0(void)
+{
+ unsigned long cr0 = percpu_read(xen_cr0_value);
+
+ if (unlikely(cr0 == 0)) {
+ cr0 = native_read_cr0();
+ percpu_write(xen_cr0_value, cr0);
+ }
+
+ return cr0;
+}
+
static void xen_write_cr0(unsigned long cr0)
{
struct multicall_space mcs;
+ percpu_write(xen_cr0_value, cr0);
+
/* Only pay attention to cr0.TS; everything else is
ignored. */
mcs = xen_mc_entry(0);
@@ -845,7 +861,7 @@ static const struct pv_cpu_ops xen_cpu_ops __initdata = {
.clts = xen_clts,
- .read_cr0 = native_read_cr0,
+ .read_cr0 = xen_read_cr0,
.write_cr0 = xen_write_cr0,
.read_cr4 = native_read_cr4,
--
1.6.0.6
next prev parent reply other threads:[~2009-05-08 0:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 20:24 [GIT PULL] Xen core updates Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 1/8] xen/x86-64: fix breakpoints and hardware watchpoints Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 2/8] xen/x86-64: clean up warnings about IST-using traps Jeremy Fitzhardinge
2009-05-07 20:24 ` Jeremy Fitzhardinge [this message]
2009-05-07 20:24 ` [PATCH 4/8] xen: deal with NMI's use of IST too Jeremy Fitzhardinge
2009-05-07 20:24 ` [PATCH 5/8] xen/i386: make sure initial VGA/ISA mappings are not overridden Jeremy Fitzhardinge
2009-05-08 10:57 ` Ingo Molnar
2009-05-08 15:08 ` Jeremy Fitzhardinge
2009-05-07 20:25 ` [PATCH 6/8] x86: use flush_tlb_others to implement flush_tlb_all Jeremy Fitzhardinge
2009-05-08 15:24 ` Ian Campbell
2009-05-08 15:49 ` Jeremy Fitzhardinge
2009-05-08 15:52 ` Ian Campbell
2009-05-11 13:09 ` [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb_all, fix tip-bot for Ian Campbell
2009-05-11 13:12 ` Ingo Molnar
2009-05-11 15:00 ` Ian Campbell
2009-05-11 15:11 ` Ingo Molnar
2009-05-11 15:39 ` Ian Campbell
2009-05-11 15:42 ` Ingo Molnar
2009-05-11 15:59 ` Ian Campbell
2009-05-11 15:40 ` Ingo Molnar
2009-05-11 15:06 ` tip-bot for Ian Campbell
2009-05-07 20:25 ` [PATCH 7/8] xen/i386: reserve Xen pagetables Jeremy Fitzhardinge
2009-05-07 20:25 ` [PATCH 8/8] xen: reserve Xen start_info rather than e820 reserving Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241727902-3176-4-git-send-email-jeremy@goop.org \
--to=jeremy@goop.org \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®