From: Jason Wessel <jason.wessel@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: kgdb-bugreport@lists.sourceforge.net, kdb@oss.sgi.com,
Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH 12/13] RFC ONLY - kgdb,kdb: use async breakpoint for sysrq for usb
Date: Fri, 8 May 2009 16:23:19 -0500 [thread overview]
Message-ID: <1241817800-9320-13-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1241817800-9320-12-git-send-email-jason.wessel@windriver.com>
This is a RFC patch. The work to possibly merge kdb and kgdb is being
evaluated and this patch is considered only a proof of concept or
prototype.
For kdb, the usb keyboard will become disabled if you use a sysrq
sequence to enter kdb. Using a tasklet solves the problem.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
kernel/kgdb.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/kernel/kgdb.c b/kernel/kgdb.c
index f303410..034f6eb 100644
--- a/kernel/kgdb.c
+++ b/kernel/kgdb.c
@@ -1817,8 +1817,18 @@ static void sysrq_handle_gdb(int key, struct tty_struct *tty)
printk(KERN_CRIT "Entering KGDB\n");
#endif
}
-
+#ifdef CONFIG_KDB_USB
+ /* XXX FIX ME XXX
+ * For now force the sysrq break point to be in a tasklet
+ * else if you send it from a usb keyboard, the keyboard cannot be
+ * used to interact with kdb because all the locks for the USB hcd
+ * device will be held. This probably needs a run time check
+ * against what i/o driver submitted the breakpoint request.
+ */
+ kgdb_schedule_breakpoint();
+#else /* ! CONFIG_KDB_USB */
kgdb_breakpoint();
+#endif /* CONFIG_KDB_USB */
}
static struct sysrq_key_op sysrq_gdb_op = {
--
1.6.3.rc0.1.gf800
next prev parent reply other threads:[~2009-05-08 21:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 21:23 [PATCH 0/13] RFC ONLY - kdb for kgdb Jason Wessel
2009-05-08 21:23 ` [PATCH 01/13] RFC ONLY - kdb: core for kgdb back end Jason Wessel
2009-05-08 21:23 ` [PATCH 02/13] RFC ONLY - kgdb: core changes to support kdb Jason Wessel
2009-05-08 21:23 ` [PATCH 03/13] RFC ONLY - kgdb,8250,pl011: Return immediately from console poll Jason Wessel
2009-05-08 21:23 ` [PATCH 04/13] RFC ONLY - kgdb: gdb "monitor" -> kdb passthrough Jason Wessel
2009-05-08 21:23 ` [PATCH 05/13] RFC ONLY - kgdboc,keyboard: Keyboard driver for kdb with kgdb Jason Wessel
2009-05-08 21:23 ` [PATCH 06/13] kgdb: remove post_primary_code references Jason Wessel
2009-05-08 21:23 ` [PATCH 07/13] RFC ONLY - x86,kgdb: Add low level debug hook Jason Wessel
2009-05-08 21:23 ` [PATCH 08/13] RFC ONLY - arm,kgdb: Add hook to catch an oops with debugger Jason Wessel
2009-05-08 21:23 ` [PATCH 09/13] RFC ONLY - powerpc,kgdb: Introduce low level trap catching Jason Wessel
2009-05-08 21:23 ` [PATCH 10/13] RFC ONLY - mips,kgdb: kdb low level trap catch and stack trace Jason Wessel
2009-05-08 21:23 ` [PATCH 11/13] kgdb: Add the ability to schedule a breakpoint via a tasklet Jason Wessel
2009-05-08 21:23 ` Jason Wessel [this message]
2009-05-08 21:23 ` [PATCH 13/13] RFC ONLY - usb,keyboard: uchi, echi, and ochi polling keyboard urbs Jason Wessel
2009-05-09 4:09 ` [PATCH 01/13] RFC ONLY - kdb: core for kgdb back end Ingo Molnar
2009-05-19 18:22 ` Jason Wessel
2009-05-08 21:49 ` [PATCH 0/13] RFC ONLY - kdb for kgdb Maxim Levitsky
2009-05-11 9:15 ` Louis Rilling
2009-05-11 9:23 ` Christoph Hellwig
2009-05-11 9:51 ` Louis Rilling
2009-05-11 9:22 ` [kdb] " Christoph Hellwig
2009-05-11 12:57 ` Martin Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241817800-9320-13-git-send-email-jason.wessel@windriver.com \
--to=jason.wessel@windriver.com \
--cc=kdb@oss.sgi.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®