From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] Split wait_noreap_copyout()
Date: Mon, 11 May 2009 15:25:50 +0200 [thread overview]
Message-ID: <1242048349-2766-2-git-send-email-v.mayatskih@gmail.com> (raw)
In-Reply-To: <1242048349-2766-1-git-send-email-v.mayatskih@gmail.com>
Move getrusage() and put_user() code from wait_noreap_copyout()
to copy_wait_opts_to_user(). The same code is spreaded across all
wait_task_*() routines, it's better to reuse one copy.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
---
kernel/exit.c | 39 +++++++++++++++++++++++----------------
1 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index 25782da..9546362 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1123,27 +1123,34 @@ static int eligible_child(struct wait_opts *wo, struct task_struct *p)
return 1;
}
-static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p,
- pid_t pid, uid_t uid, int why, int status)
+static int copy_wait_opts_to_user(struct wait_opts *wo, struct task_struct *p,
+ pid_t pid, uid_t uid, int why, int status, int signal)
{
- struct siginfo __user *infop;
+ struct siginfo __user *infop = wo->wo_info;
int retval = wo->wo_rusage
? getrusage(p, RUSAGE_BOTH, wo->wo_rusage) : 0;
+ if (!retval && infop) {
+ retval = put_user(signal, &infop->si_signo);
+ if (!retval)
+ retval = put_user(0, &infop->si_errno);
+ if (!retval)
+ retval = put_user((short)why, &infop->si_code);
+ if (!retval)
+ retval = put_user(pid, &infop->si_pid);
+ if (!retval)
+ retval = put_user(uid, &infop->si_uid);
+ if (!retval)
+ retval = put_user(status, &infop->si_status);
+ }
+ return retval;
+}
+
+static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p,
+ pid_t pid, uid_t uid, int why, int status)
+{
+ int retval = copy_wait_opts_to_user(wo, p, pid, uid, why, status, SIGCHLD);
put_task_struct(p);
- infop = wo->wo_info;
- if (!retval)
- retval = put_user(SIGCHLD, &infop->si_signo);
- if (!retval)
- retval = put_user(0, &infop->si_errno);
- if (!retval)
- retval = put_user((short)why, &infop->si_code);
- if (!retval)
- retval = put_user(pid, &infop->si_pid);
- if (!retval)
- retval = put_user(uid, &infop->si_uid);
- if (!retval)
- retval = put_user(status, &infop->si_status);
if (!retval)
retval = pid;
return retval;
--
1.6.2.2
next prev parent reply other threads:[~2009-05-11 13:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 13:25 [PATCH 0/5] wait_task_* cleanups V2 Vitaly Mayatskikh
2009-05-11 13:25 ` Vitaly Mayatskikh [this message]
2009-05-11 23:45 ` [PATCH 1/5] Split wait_noreap_copyout() Andrew Morton
2009-05-20 15:21 ` Vitaly Mayatskikh
2009-05-20 15:57 ` Oleg Nesterov
2009-05-20 20:29 ` Roland McGrath
2009-05-20 18:21 ` Ingo Molnar
2009-05-21 14:12 ` Oleg Nesterov
2009-05-21 14:35 ` Vitaly Mayatskikh
2009-06-09 15:14 ` Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 2/5] Use copy_wait_opts_to_user() in wait_task_stopped() Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 3/5] Use copy_wait_opts_to_user() in do_wait() Vitaly Mayatskikh
2009-06-15 16:39 ` Oleg Nesterov
2009-05-11 13:25 ` [PATCH 4/5] Use copy_wait_opts_to_user() in wait_task_zombie() Vitaly Mayatskikh
2009-06-15 16:43 ` Oleg Nesterov
2009-05-11 13:25 ` [PATCH 5/5] Use copy_wait_opts_to_user() in wait_task_continued() Vitaly Mayatskikh
2009-06-15 16:55 ` Oleg Nesterov
2009-06-15 17:13 ` Oleg Nesterov
2009-06-15 17:16 ` Andrew Morton
2009-05-12 3:19 ` [PATCH 0/5] wait_task_* cleanups V2 Roland McGrath
-- strict thread matches above, loose matches on Subject: below --
2009-05-11 10:12 [PATCH 0/5] wait_task_* cleanups Vitaly Mayatskikh
2009-05-11 10:12 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 10:20 ` Ingo Molnar
2009-05-11 11:20 ` Vitaly Mayatskikh
2009-05-11 12:04 ` Christoph Hellwig
2009-05-11 12:17 ` Ingo Molnar
2009-05-11 20:47 ` Vitaly Mayatskikh
2009-05-11 21:04 ` Ingo Molnar
2009-05-11 12:17 ` Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242048349-2766-2-git-send-email-v.mayatskih@gmail.com \
--to=v.mayatskih@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®