mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] wait_task_* cleanups V2
Date: Mon, 11 May 2009 20:19:32 -0700 (PDT)	[thread overview]
Message-ID: <20090512031932.2FD67FC35D@magilla.sf.frob.com> (raw)
In-Reply-To: Vitaly Mayatskikh's message of  Monday, 11 May 2009 15:25:49 +0200 <1242048349-2766-1-git-send-email-v.mayatskih@gmail.com>

Oleg is out this week, and we should let him react.
It looks generally good to me.

Can't the wo_stat handling be rolled into copy_wait_opts_to_user too?
Also it looks like every(?) caller does:
	if (!retval)
		retval = pid;
so why not roll that into copy_wait_opts_to_user too?


Thanks,
Roland

      parent reply	other threads:[~2009-05-12  3:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 13:25 Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 1/5] Split wait_noreap_copyout() Vitaly Mayatskikh
2009-05-11 23:45   ` Andrew Morton
2009-05-20 15:21   ` Vitaly Mayatskikh
2009-05-20 15:57     ` Oleg Nesterov
2009-05-20 20:29       ` Roland McGrath
2009-05-20 18:21     ` Ingo Molnar
2009-05-21 14:12       ` Oleg Nesterov
2009-05-21 14:35         ` Vitaly Mayatskikh
2009-06-09 15:14   ` Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 2/5] Use copy_wait_opts_to_user() in wait_task_stopped() Vitaly Mayatskikh
2009-05-11 13:25 ` [PATCH 3/5] Use copy_wait_opts_to_user() in do_wait() Vitaly Mayatskikh
2009-06-15 16:39   ` Oleg Nesterov
2009-05-11 13:25 ` [PATCH 4/5] Use copy_wait_opts_to_user() in wait_task_zombie() Vitaly Mayatskikh
2009-06-15 16:43   ` Oleg Nesterov
2009-05-11 13:25 ` [PATCH 5/5] Use copy_wait_opts_to_user() in wait_task_continued() Vitaly Mayatskikh
2009-06-15 16:55   ` Oleg Nesterov
2009-06-15 17:13     ` Oleg Nesterov
2009-06-15 17:16     ` Andrew Morton
2009-05-12  3:19 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090512031932.2FD67FC35D@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=v.mayatskih@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®