From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, jmorris@namei.org
Subject: Re: [PATCH 1/3] IMA: use current_cred() instead of current->cred
Date: Mon, 11 May 2009 19:16:22 -0400 [thread overview]
Message-ID: <1242083782.4131.2.camel@dyn9002018117.watson.ibm.com> (raw)
In-Reply-To: <20090511175909.7719.94816.stgit@dhcp231-142.rdu.redhat.com>
On Mon, 2009-05-11 at 13:59 -0400, Eric Paris wrote:
> Proper invocation of the current credentials is to use current_cred() not
> current->cred. This patches makes IMA use the new method.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
acked-by: Mimi Zohar <zohar@us.ibm.com>
> ---
>
> security/integrity/ima/ima_audit.c | 2 +-
> security/integrity/ima/ima_main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/integrity/ima/ima_audit.c b/security/integrity/ima/ima_audit.c
> index b628eea..ff513ff 100644
> --- a/security/integrity/ima/ima_audit.c
> +++ b/security/integrity/ima/ima_audit.c
> @@ -41,7 +41,7 @@ void integrity_audit_msg(int audit_msgno, struct inode *inode,
>
> ab = audit_log_start(current->audit_context, GFP_KERNEL, audit_msgno);
> audit_log_format(ab, "integrity: pid=%d uid=%u auid=%u ses=%u",
> - current->pid, current->cred->uid,
> + current->pid, current_cred()->uid,
> audit_get_loginuid(current),
> audit_get_sessionid(current));
> audit_log_task_context(ab);
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 122f17f..cdae13c 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -184,7 +184,7 @@ int ima_path_check(struct path *path, int mask)
> struct dentry *dentry = dget(path->dentry);
> struct vfsmount *mnt = mntget(path->mnt);
>
> - file = dentry_open(dentry, mnt, O_RDONLY, current->cred);
> + file = dentry_open(dentry, mnt, O_RDONLY, current_cred());
> rc = get_path_measurement(iint, file, dentry->d_name.name);
> }
> out:
>
next prev parent reply other threads:[~2009-05-11 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 17:59 Eric Paris
2009-05-11 17:59 ` [PATCH 2/3] IMA: Handle dentry_open failures Eric Paris
2009-05-11 23:18 ` Mimi Zohar
2009-05-11 17:59 ` [PATCH 3/3] IMA: open all files O_LARGEFILE Eric Paris
2009-05-11 23:17 ` Mimi Zohar
2009-05-11 23:16 ` Mimi Zohar [this message]
2009-05-12 1:35 ` [PATCH 1/3] IMA: use current_cred() instead of current->cred James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242083782.4131.2.camel@dyn9002018117.watson.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®