From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, jmorris@namei.org
Subject: Re: [PATCH 3/3] IMA: open all files O_LARGEFILE
Date: Mon, 11 May 2009 19:17:07 -0400 [thread overview]
Message-ID: <1242083827.4131.3.camel@dyn9002018117.watson.ibm.com> (raw)
In-Reply-To: <20090511175922.7719.32980.stgit@dhcp231-142.rdu.redhat.com>
On Mon, 2009-05-11 at 13:59 -0400, Eric Paris wrote:
> If IMA tried to measure a file which was larger than 4G dentry_open would fail
> with -EOVERFLOW since IMA wasn't passing O_LARGEFILE. This patch passes
> O_LARGEFILE to all IMA opens to avoid this problem.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
> ---
>
> security/integrity/ima/ima_main.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 1987424..c4228c0 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -180,7 +180,8 @@ int ima_path_check(struct path *path, int mask)
> struct dentry *dentry = dget(path->dentry);
> struct vfsmount *mnt = mntget(path->mnt);
>
> - file = dentry_open(dentry, mnt, O_RDONLY, current_cred());
> + file = dentry_open(dentry, mnt, O_RDONLY | O_LARGEFILE,
> + current_cred());
> if (IS_ERR(file)) {
> pr_info("%s dentry_open failed\n", dentry->d_name.name);
> rc = PTR_ERR(file);
>
next prev parent reply other threads:[~2009-05-11 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 17:59 [PATCH 1/3] IMA: use current_cred() instead of current->cred Eric Paris
2009-05-11 17:59 ` [PATCH 2/3] IMA: Handle dentry_open failures Eric Paris
2009-05-11 23:18 ` Mimi Zohar
2009-05-11 17:59 ` [PATCH 3/3] IMA: open all files O_LARGEFILE Eric Paris
2009-05-11 23:17 ` Mimi Zohar [this message]
2009-05-11 23:16 ` [PATCH 1/3] IMA: use current_cred() instead of current->cred Mimi Zohar
2009-05-12 1:35 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242083827.4131.3.camel@dyn9002018117.watson.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®