From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug(
Date: Fri, 15 May 2009 18:56:46 +0000 [thread overview]
Message-ID: <1242413806.22585.2.camel@mulgrave.int.hansenpartnership.com> (raw)
In-Reply-To: <d6d5dc09d259cc1da0fef2b1e9c6b7588cccf0b4.1242407227.git.joe@perches.com>
On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote:
> From: Joe Perches <joe@perches.com>
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/scsi/aha1542.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index 8059494..29d5118 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost)
> if (mbistatus == 3)
> continue; /* Aborted command not found */
>
> -#ifdef DEBUG
> - printk(KERN_DEBUG "...done %d %d\n", mbo, mbi);
> -#endif
> + pr_debug("...done %d %d\n", mbo, mbi);
This one looks dangerous ... that's a per trigger printk from interrupt
context. That's a lot of stuff to bung in the log buffer for a normal
operating case (which is pretty interrupt heavy). What does this do to
system responsiveness?
James
next prev parent reply other threads:[~2009-05-15 18:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 17:59 [PATCH 00/11] Change #ifdef DEBUG printk(KERN_DEBUG to pr_debug Joe Perches
2009-05-15 17:59 ` [PATCH 01/11] arch/arm: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug( Joe Perches
2009-05-15 17:59 ` [PATCH 02/11] arch/h8300: " Joe Perches
2009-05-15 17:59 ` [PATCH 03/11] arch/m68knommu: " Joe Perches
2009-05-18 1:33 ` Greg Ungerer
2009-05-15 17:59 ` [PATCH 04/11] arch/powerpc: " Joe Perches
2009-05-15 17:59 ` [PATCH 05/11] arch/um: " Joe Perches
2009-05-15 17:59 ` [PATCH 06/11] drivers/isdn: " Joe Perches
2009-05-15 17:59 ` [PATCH 07/11] drivers/macintosh: " Joe Perches
2009-05-15 17:59 ` [PATCH 08/11] drivers/net: " Joe Perches
2009-05-15 17:59 ` [PATCH 09/11] drivers/scsi: " Joe Perches
2009-05-15 18:56 ` James Bottomley [this message]
2009-05-15 19:04 ` Joe Perches
2009-05-15 17:59 ` [PATCH 10/11] fs/efs: " Joe Perches
2009-05-15 17:59 ` [PATCH 11/11] mm: " Joe Perches
2009-05-15 18:56 ` Serge E. Hallyn
2009-05-15 19:40 ` Joe Perches
2009-05-15 19:40 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242413806.22585.2.camel@mulgrave.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®