mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Neil Turton <nturton@solarflare.com>,
	Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 2/4] amd-iommu: fix the handling of device aliases in the AMD IOMMU driver.
Date: Fri, 22 May 2009 14:06:29 +0200	[thread overview]
Message-ID: <1242993991-28613-3-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1242993991-28613-1-git-send-email-joerg.roedel@amd.com>

From: Neil Turton <nturton@solarflare.com>

[ impact: set flags for the right req-id in the device table ]

The devid parameter to set_dev_entry_from_acpi is the requester ID
rather than the device ID since it is used to index the IOMMU device
table.  The handling of IVHD_DEV_ALIAS used to pass the device ID.
This patch fixes it to pass the requester ID.

Signed-off-by: Neil Turton <nturton@solarflare.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 35fc965..53f93db 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -618,7 +618,7 @@ static void __init init_iommu_from_acpi(struct amd_iommu *iommu,
 		case IVHD_DEV_ALIAS:
 			devid = e->devid;
 			devid_to = e->ext >> 8;
-			set_dev_entry_from_acpi(iommu, devid, e->flags, 0);
+			set_dev_entry_from_acpi(iommu, devid_to, e->flags, 0);
 			amd_iommu_alias_table[devid] = devid_to;
 			break;
 		case IVHD_DEV_ALIAS_RANGE:
-- 
1.6.3.1



  parent reply	other threads:[~2009-05-22 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 12:06 [PATCH 0/4] amd-iommu fixes for 2.6.31 Joerg Roedel
2009-05-22 12:06 ` [PATCH 1/4] amd-iommu: fix an off-by-one error in the AMD IOMMU driver Joerg Roedel
2009-05-22 12:06 ` Joerg Roedel [this message]
2009-05-22 12:06 ` [PATCH 3/4] amd-iommu: make sure only ivmd entries are parsed Joerg Roedel
2009-05-22 12:06 ` [PATCH 4/4] amd iommu: properly detach from protection domain on ->remove Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242993991-28613-3-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nturton@solarflare.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®