From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 3/4] amd-iommu: make sure only ivmd entries are parsed
Date: Fri, 22 May 2009 14:06:30 +0200 [thread overview]
Message-ID: <1242993991-28613-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1242993991-28613-1-git-send-email-joerg.roedel@amd.com>
[ impact: protect against broken ivrs acpi table ]
The bug never triggered. But it should be fixed to protect against
broken ACPI tables in the future.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/kernel/amd_iommu_init.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
index 53f93db..a3a2b98 100644
--- a/arch/x86/kernel/amd_iommu_init.c
+++ b/arch/x86/kernel/amd_iommu_init.c
@@ -906,6 +906,8 @@ static int __init init_unity_map_range(struct ivmd_header *m)
switch (m->type) {
default:
+ kfree(e);
+ return 0;
case ACPI_IVMD_TYPE:
e->devid_start = e->devid_end = m->devid;
break;
--
1.6.3.1
next prev parent reply other threads:[~2009-05-22 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 12:06 [PATCH 0/4] amd-iommu fixes for 2.6.31 Joerg Roedel
2009-05-22 12:06 ` [PATCH 1/4] amd-iommu: fix an off-by-one error in the AMD IOMMU driver Joerg Roedel
2009-05-22 12:06 ` [PATCH 2/4] amd-iommu: fix the handling of device aliases " Joerg Roedel
2009-05-22 12:06 ` Joerg Roedel [this message]
2009-05-22 12:06 ` [PATCH 4/4] amd iommu: properly detach from protection domain on ->remove Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242993991-28613-4-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®