From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 2/5] tracing/events: change the type of __str_loc_item to unsigned short
Date: Tue, 26 May 2009 04:04:47 +0200 [thread overview]
Message-ID: <1243303490-8019-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1243303490-8019-1-git-send-email-fweisbec@gmail.com>
From: Li Zefan <lizf@cn.fujitsu.com>
When defining a dynamic size string, we add __str_loc_##item to the
trace entry, and it stores the location of the actual string in
entry->_str_data[]
'unsigned short' should be sufficient to store this information, thus
we save 2 bytes per dyn-size string in the ring buffer.
[ Impact: reduce memory occupied by dyn-size strings in ring buffer ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <4A14EDB6.2050507@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
include/trace/ftrace.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
index edb02bc..b5ff2e8 100644
--- a/include/trace/ftrace.h
+++ b/include/trace/ftrace.h
@@ -25,7 +25,7 @@
#define __field(type, item) type item;
#undef __string
-#define __string(item, src) int __str_loc_##item;
+#define __string(item, src) unsigned short __str_loc_##item;
#undef TP_STRUCT__entry
#define TP_STRUCT__entry(args...) args
--
1.6.2.3
next prev parent reply other threads:[~2009-05-26 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 2:04 [PATCH 0/5] tracing/core: various fixes Frederic Weisbecker
2009-05-26 2:04 ` [PATCH 1/5] tracing: add trace_event_read_lock() Frederic Weisbecker
2009-05-26 2:04 ` Frederic Weisbecker [this message]
2009-05-26 2:04 ` [PATCH 3/5] kmemtrace: fix kernel parameter documentation Frederic Weisbecker
2009-05-26 2:04 ` [PATCH 4/5] ftrace: Add task_comm support for trace_event Frederic Weisbecker
2009-05-26 2:04 ` [PATCH 5/5] ftrace: clean up of using ftrace_event_enable_disable() Frederic Weisbecker
2009-05-26 18:55 ` [GIT PULL v2][PATCH 0/10] tracing/core: various fixes Frederic Weisbecker
2009-05-26 21:30 ` Steven Rostedt
2009-05-26 22:22 ` Frederic Weisbecker
2009-05-26 19:46 ` [PATCH 0/5] " Steven Rostedt
2009-05-26 20:06 ` Frederic Weisbecker
2009-05-26 21:10 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243303490-8019-3-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®