mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] imx_udc: don't queue more data when zlp is to be sent
@ 2009-05-28 11:00 Daniel Glöckner
  0 siblings, 0 replies; only message in thread
From: Daniel Glöckner @ 2009-05-28 11:00 UTC (permalink / raw)
  To: Darius Augulis, David Brownell
  Cc: linux-usb, linux-kernel, Daniel Glöckner

When a zero-length packet has been requested and another packet is
written into the fifo, the MX1 tends to send the first byte of the
previous packet instead of the first byte of the current packet.
The CRC is adjusted accordingly so that this packet is _not_
discarded by the host.

Waiting for the ZLPS bit to clear avoids these bad packets.

Signed-off-by: Daniel Glöckner <dg@emlix.com>
---
 drivers/usb/gadget/imx_udc.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/imx_udc.c b/drivers/usb/gadget/imx_udc.c
index ff7658e..642cceb 100644
--- a/drivers/usb/gadget/imx_udc.c
+++ b/drivers/usb/gadget/imx_udc.c
@@ -415,6 +415,13 @@ static int write_packet(struct imx_ep_struct *imx_ep, struct imx_request *req)
 	u8	*buf;
 	int	length, count, temp;
 
+	if (unlikely(__raw_readl(imx_ep->imx_usb->base +
+				 USB_EP_STAT(EP_NO(imx_ep))) & EPSTAT_ZLPS)) {
+		D_TRX(imx_ep->imx_usb->dev, "<%s> zlp still queued in EP %s\n",
+			__func__, imx_ep->ep.name);
+		return -1;
+	}
+
 	buf = req->req.buf + req->req.actual;
 	prefetch(buf);
 
-- 
1.6.1.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-05-28 11:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-28 11:00 [PATCH] imx_udc: don't queue more data when zlp is to be sent Daniel Glöckner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®