linux-next: net/wireless tree build failure

linux-next: net/wireless tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

Hi John, Dave,

Today's linux-next build (pmac32 defconfig) failed like this:

In file included from drivers/net/wireless/b43/phy_common.h:5,
                 from drivers/net/wireless/b43/phy_common.c:30:
include/linux/rfkill.h: In function 'rfkill_alloc':
include/linux/rfkill.h:279: error: implicit declaration of function 'ERR_PTR'
include/linux/rfkill.h:279: warning: return makes pointer from integer without a cast
include/linux/rfkill.h: In function 'rfkill_register':
include/linux/rfkill.h:284: warning: comparison between pointer and integer
In file included from include/linux/dma-mapping.h:6,
                 from arch/powerpc/include/asm/pci.h:16,
                 from include/linux/pci.h:1101,
                 from include/linux/ssb/ssb.h:9,
                 from drivers/net/wireless/b43/b43.h:9,
                 from drivers/net/wireless/b43/phy_common.c:35:
include/linux/err.h: At top level:
include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
include/linux/rfkill.h:279: note: previous implicit declaration of 'ERR_PTR' was here

Probably caused by commit 19d337dff95cbf76edd3ad95c0cee2732c3e1ec5
("rfkill: rewrite") which added uses of ERR_PTR to inlines in rfkill.h
but did not include linux/err.h.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: net/wireless tree build failure

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

On Tue, 2009-06-09 at 23:33 +1000, Stephen Rothwell wrote:

> Probably caused by commit 19d337dff95cbf76edd3ad95c0cee2732c3e1ec5
> ("rfkill: rewrite") which added uses of ERR_PTR to inlines in rfkill.h
> but did not include linux/err.h.

Indeed. Something must be including linux/err.h for me, I'll send a fix.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: linux-next: net/wireless tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi Johannes,

On Tue, 09 Jun 2009 15:54:42 +0200 Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Tue, 2009-06-09 at 23:33 +1000, Stephen Rothwell wrote:
> 
> > Probably caused by commit 19d337dff95cbf76edd3ad95c0cee2732c3e1ec5
> > ("rfkill: rewrite") which added uses of ERR_PTR to inlines in rfkill.h
> > but did not include linux/err.h.
> 
> Indeed. Something must be including linux/err.h for me, I'll send a fix.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]