* [PATCH -tip] x86: amd_iommu.c device_nb should be static
@ 2009-06-18 10:56 Jaswinder Singh Rajput
2009-06-20 7:47 ` [AMD-IOMMU] " Jaswinder Singh Rajput
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-18 10:56 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, Joerg Roedel, LKML
device_nb is used only by same file, it should be static.
Also fixed NULL pointer issue.
Fixed following sparse warnings :
arch/x86/kernel/amd_iommu.c:1195:23: warning: symbol 'device_nb' was not declared. Should it be static?
arch/x86/kernel/amd_iommu.c:1766:10: warning: Using plain integer as NULL pointer
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/amd_iommu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 9372f04..6c99f50 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -1192,7 +1192,7 @@ out:
return 0;
}
-struct notifier_block device_nb = {
+static struct notifier_block device_nb = {
.notifier_call = device_change_notifier,
};
@@ -1763,7 +1763,7 @@ static void *alloc_coherent(struct device *dev, size_t size,
flag |= __GFP_ZERO;
virt_addr = (void *)__get_free_pages(flag, get_order(size));
if (!virt_addr)
- return 0;
+ return NULL;
paddr = virt_to_phys(virt_addr);
--
1.6.0.6
^ permalink raw reply [flat|nested] 2+ messages in thread* [AMD-IOMMU] amd_iommu.c device_nb should be static
2009-06-18 10:56 [PATCH -tip] x86: amd_iommu.c device_nb should be static Jaswinder Singh Rajput
@ 2009-06-20 7:47 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 7:47 UTC (permalink / raw)
To: Joerg Roedel, Ingo Molnar; +Cc: x86 maintainers, LKML
device_nb is used only by same file, it should be static.
Also fixed NULL pointer issue.
Fixed following sparse warnings :
arch/x86/kernel/amd_iommu.c:1195:23: warning: symbol 'device_nb' was not declared. Should it be static?
arch/x86/kernel/amd_iommu.c:1766:10: warning: Using plain integer as NULL pointer
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kernel/amd_iommu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 9372f04..6c99f50 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -1192,7 +1192,7 @@ out:
return 0;
}
-struct notifier_block device_nb = {
+static struct notifier_block device_nb = {
.notifier_call = device_change_notifier,
};
@@ -1763,7 +1763,7 @@ static void *alloc_coherent(struct device *dev, size_t size,
flag |= __GFP_ZERO;
virt_addr = (void *)__get_free_pages(flag, get_order(size));
if (!virt_addr)
- return 0;
+ return NULL;
paddr = virt_to_phys(virt_addr);
--
1.6.0.6
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-20 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-18 10:56 [PATCH -tip] x86: amd_iommu.c device_nb should be static Jaswinder Singh Rajput
2009-06-20 7:47 ` [AMD-IOMMU] " Jaswinder Singh Rajput
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome