From: Joe Perches <joe@perches.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, kevin.huang@rdc.com.tw, greg@kroah.com
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices
Date: Wed, 24 Jun 2009 09:38:23 -0700 [thread overview]
Message-ID: <1245861503.29098.102.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20090624170944.24250.99267.stgit@t61.ukuu.org.uk>
On Wed, 2009-06-24 at 18:10 +0100, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
> diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c
> new file mode 100644
> index 0000000..0f40cab
> --- /dev/null
> +++ b/drivers/ata/pata_rdc.c
[]
> +static void rdc_set_piomode(struct ata_port *ap, struct ata_device *adev)
> +{
[]
> + static const /* ISP RTC */
> + u8 timings[][2] = { { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
[]
> +static void do_rdc_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> +{
> + static const /* ISP RTC */
> + u8 timings[][2] = { { 0, 0 },
> + { 0, 0 },
> + { 1, 0 },
> + { 2, 1 },
> + { 2, 3 }, };
Maybe consolidate?
The code seems to have many magic constants that might
be better #define'd and or'd.
next prev parent reply other threads:[~2009-06-24 16:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 17:10 Alan Cox
2009-06-24 16:38 ` Joe Perches [this message]
2009-06-24 16:42 ` Alan Cox
2009-06-24 17:29 Alan Cox
2009-06-24 19:35 ` Jeff Garzik
2009-06-24 22:55 ` Alan Cox
2009-06-24 23:33 ` Joe Perches
2009-06-24 23:38 ` Jeff Garzik
2009-06-25 4:27 ` Kevin Huang (黃凱文)
2009-07-29 1:16 ` Jeff Garzik
2009-07-29 2:53 ` Greg KH
2009-07-29 3:05 ` Jeff Garzik
2009-07-29 3:37 ` Stephen Rothwell
2009-07-29 13:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1245861503.29098.102.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=kevin.huang@rdc.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®