From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel@vger.kernel.org, kevin.huang@rdc.com.tw,
greg@kroah.com,
Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices
Date: Wed, 24 Jun 2009 23:55:48 +0100 [thread overview]
Message-ID: <20090624235548.681b8992@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4A42800D.6020202@garzik.org>
> Seems fine and fairly straightforward to me. My lone comment -- go
> through and replace magic numbers with named constants, for e.g. the PCI
> config registers that program timings...
Its based on your ata_piix driver. Feel free to update that and I'll pull
names and things across to match.
next prev parent reply other threads:[~2009-06-24 22:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 17:29 Alan Cox
2009-06-24 19:35 ` Jeff Garzik
2009-06-24 22:55 ` Alan Cox [this message]
2009-06-24 23:33 ` Joe Perches
2009-06-24 23:38 ` Jeff Garzik
2009-06-25 4:27 ` Kevin Huang (黃凱文)
2009-07-29 1:16 ` Jeff Garzik
2009-07-29 2:53 ` Greg KH
2009-07-29 3:05 ` Jeff Garzik
2009-07-29 3:37 ` Stephen Rothwell
2009-07-29 13:56 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2009-06-24 17:10 Alan Cox
2009-06-24 16:38 ` Joe Perches
2009-06-24 16:42 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624235548.681b8992@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=kevin.huang@rdc.com.tw \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®