* [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel
@ 2009-07-06 16:19 Nicolas Ferre
2009-07-07 7:12 ` Haavard Skinnemoen
2009-07-07 14:24 ` Sosnowski, Maciej
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Ferre @ 2009-07-06 16:19 UTC (permalink / raw)
To: dan.j.williams, maciej.sosnowski, linux-arm-kernel, haavard.skinnemoen
Cc: patrice.vilchez, linux-kernel, nicolas.ferre
It seems that thread_count is not properly calculated in dmatest.
In fact the thread count number that is returned from dmatest_add_threads() is
not correctly added to the thread_count and thus not properly printed.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/dma/dmatest.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 4262ff9..921c5f2 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -508,11 +508,11 @@ static int dmatest_add_channel(struct dma_chan *chan)
if (dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(dtc, DMA_MEMCPY);
- thread_count += cnt > 0 ?: 0;
+ thread_count += cnt > 0 ? cnt : 0;
}
if (dma_has_cap(DMA_XOR, dma_dev->cap_mask)) {
cnt = dmatest_add_threads(dtc, DMA_XOR);
- thread_count += cnt > 0 ?: 0;
+ thread_count += cnt > 0 ? cnt : 0;
}
pr_info("dmatest: Started %u threads using %s\n",
--
1.5.3.7
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel
2009-07-06 16:19 [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel Nicolas Ferre
@ 2009-07-07 7:12 ` Haavard Skinnemoen
2009-07-07 14:24 ` Sosnowski, Maciej
1 sibling, 0 replies; 3+ messages in thread
From: Haavard Skinnemoen @ 2009-07-07 7:12 UTC (permalink / raw)
To: Nicolas Ferre
Cc: dan.j.williams, maciej.sosnowski, linux-arm-kernel,
patrice.vilchez, linux-kernel, nicolas.ferre
Nicolas Ferre wrote:
> It seems that thread_count is not properly calculated in dmatest.
> In fact the thread count number that is returned from dmatest_add_threads() is
> not correctly added to the thread_count and thus not properly printed.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel
2009-07-06 16:19 [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel Nicolas Ferre
2009-07-07 7:12 ` Haavard Skinnemoen
@ 2009-07-07 14:24 ` Sosnowski, Maciej
1 sibling, 0 replies; 3+ messages in thread
From: Sosnowski, Maciej @ 2009-07-07 14:24 UTC (permalink / raw)
To: Nicolas Ferre
Cc: Williams, Dan J, linux-arm-kernel, haavard.skinnemoen,
patrice.vilchez, linux-kernel
Nicolas Ferre wrote:
> It seems that thread_count is not properly calculated in dmatest.
> In fact the thread count number that is returned from dmatest_add_threads() is
> not correctly added to the thread_count and thus not properly printed.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-07 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-06 16:19 [PATCH] dmaengine: dmatest: correct thread_count while using multiple thread per channel Nicolas Ferre
2009-07-07 7:12 ` Haavard Skinnemoen
2009-07-07 14:24 ` Sosnowski, Maciej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®