'config EVENT_PROFILE' - how does it ever work?

'config EVENT_PROFILE' - how does it ever work?

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Peter - where do you prefer your e-mail?  MAINTAINERS for 'perf' gives this
chello.nl address, but peterz@infradead.org for other stuff? Sending to both
just in case...

Found this while trying to figure out why there was a one-entry menu
for performance counters.

Commit e077df4f adds to init/Kconfig this code:

config EVENT_PROFILE
        bool "Tracepoint profile sources"
        depends on PERF_COUNTERS && EVENT_TRACER
        default y

But there's no other usage of EVENT_TRACER I can find other than a lot
of 'EVENT_TRACER is not set' entries in defconfigs.  Is this an actual bug,
or did I lose the plot someplace?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 'config EVENT_PROFILE' - how does it ever work?

[Peter Zijlstra]

On Tue, 2009-07-07 at 09:33 -0400, Valdis.Kletnieks@vt.edu wrote:
> Peter - where do you prefer your e-mail?  MAINTAINERS for 'perf' gives this
> chello.nl address, but peterz@infradead.org for other stuff? Sending to both
> just in case...

either work, they end up in the same inbox ;-)

> Found this while trying to figure out why there was a one-entry menu
> for performance counters.
> 
> Commit e077df4f adds to init/Kconfig this code:
> 
> config EVENT_PROFILE
>         bool "Tracepoint profile sources"
>         depends on PERF_COUNTERS && EVENT_TRACER
>         default y
> 
> But there's no other usage of EVENT_TRACER I can find other than a lot
> of 'EVENT_TRACER is not set' entries in defconfigs.  Is this an actual bug,
> or did I lose the plot someplace?

It used to work at some point in the past, but then I think it bitrotted
a bit with the tracer changes. I think Jason Baron posted a few patches
yesterday that fixed it all up and made it work nicely again.

http://lkml.org/lkml/2009/7/6/313

Re: 'config EVENT_PROFILE' - how does it ever work?

[Peter Zijlstra]

On Tue, 2009-07-07 at 16:34 +0200, Peter Zijlstra wrote:
> On Tue, 2009-07-07 at 09:33 -0400, Valdis.Kletnieks@vt.edu wrote:
> > Peter - where do you prefer your e-mail?  MAINTAINERS for 'perf' gives this
> > chello.nl address, but peterz@infradead.org for other stuff? Sending to both
> > just in case...
> 
> either work, they end up in the same inbox ;-)

That said, infradead has proven to be more reliable than chello.nl since
my ISP at times does weird things, and some headers seem to confuse its
filters.

I should probably send a patch to make all the email addies the same.

Re: 'config EVENT_PROFILE' - how does it ever work?

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

On Tue, 07 Jul 2009 16:34:55 +0200, Peter Zijlstra said:
> It used to work at some point in the past, but then I think it bitrotted
> a bit with the tracer changes. I think Jason Baron posted a few patches
> yesterday that fixed it all up and made it work nicely again.
> 
> http://lkml.org/lkml/2009/7/6/313

I stuck Jason's patches on my tree, and EVENT_PROFILE is again visible
in 'make menuconfig'.  So I'm going to assume that the appropriate maintainer
is going to shepherd these into mainline - looks small enough, and it's mostly
a bitrot-fix, that Linus may accept it for .31. If not, .32 isn't *that* far
off.. ;)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]