From: Felipe Balbi <me@felipebalbi.com>
To: dwmw2@infradead.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <me@felipebalbi.com>
Subject: [rfc/patch 13/15] power: bq27200: RSOC is 8-bit wide
Date: Sun, 12 Jul 2009 21:09:35 +0300 [thread overview]
Message-ID: <1247422177-7329-13-git-send-email-me@felipebalbi.com> (raw)
In-Reply-To: <1247422177-7329-12-git-send-email-me@felipebalbi.com>
no need for shifting, just read 8-bits.
Signed-off-by: Felipe Balbi <me@felipebalbi.com>
---
drivers/power/bq27200_battery.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/bq27200_battery.c b/drivers/power/bq27200_battery.c
index dd1b2f2..85e824a 100644
--- a/drivers/power/bq27200_battery.c
+++ b/drivers/power/bq27200_battery.c
@@ -159,13 +159,13 @@ static int bq27200_rsoc(struct bq27200 *bq)
{
int ret;
- ret = bq27200_readw(bq, BQ27200_REG_RSOC);
+ ret = bq27200_readb(bq, BQ27200_REG_RSOC);
if (ret < 0) {
dev_err(&bq->client->dev, "error reading relative State-of-Charge\n");
return ret;
}
- return ret >> 8;
+ return ret;
}
static int bq27200_power(struct bq27200 *bq)
--
1.6.1.3
next prev parent reply other threads:[~2009-07-12 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 18:09 [rfc/patch 01/15] power: bq27x00: rename to bq27200.c Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 02/15] power: bq27200: this is an i2c device Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 03/15] power: bq27200: misc cleanup Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 04/15] power: bq27200: simplify read by using smbus Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 05/15] power: bq27200: remove unnecessary function Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 06/15] power: bq27200: rename structure to something smaller Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 07/15] power: bq27200: add missing suplicants Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 08/15] power: bq27200: define all register space Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 09/15] power: bq27200: fix up current reporting Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 10/15] power: bq27200: voltage should be expressed in uV Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 11/15] power: bq27200: temperature in tenths of degrees Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 12/15] power: bq27200: add power property Felipe Balbi
2009-07-12 18:09 ` Felipe Balbi [this message]
2009-07-12 18:09 ` [rfc/patch 14/15] power: bq27200: add time to empty/full Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 15/15] power: bq27200: add energy average Felipe Balbi
2009-07-12 20:12 ` [rfc/patch 14/15] power: bq27200: add time to empty/full Felipe Balbi
2009-07-12 20:11 ` [rfc/patch 12/15] power: bq27200: add power property Felipe Balbi
2009-07-12 18:47 ` [rfc/patch 02/15] power: bq27200: this is an i2c device Linus Walleij
2009-07-12 19:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247422177-7329-13-git-send-email-me@felipebalbi.com \
--to=me@felipebalbi.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®