mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: dwmw2@infradead.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <me@felipebalbi.com>
Subject: [rfc/patch 03/15] power: bq27200: misc cleanup
Date: Sun, 12 Jul 2009 21:09:25 +0300	[thread overview]
Message-ID: <1247422177-7329-3-git-send-email-me@felipebalbi.com> (raw)
In-Reply-To: <1247422177-7329-2-git-send-email-me@felipebalbi.com>

whitespaces, tabs, unnecessary prints... the usual.

Signed-off-by: Felipe Balbi <me@felipebalbi.com>
---
 drivers/power/bq27200_battery.c |   40 ++++++++++++--------------------------
 1 files changed, 13 insertions(+), 27 deletions(-)

diff --git a/drivers/power/bq27200_battery.c b/drivers/power/bq27200_battery.c
index 1978cd9..3eb0f5a 100644
--- a/drivers/power/bq27200_battery.c
+++ b/drivers/power/bq27200_battery.c
@@ -39,7 +39,7 @@ struct bq27200_access_methods {
 };
 
 struct bq27200_device_info {
-	struct device 		*dev;
+	struct device		*dev;
 	int			voltage_uV;
 	int			current_uA;
 	int			temp_C;
@@ -50,6 +50,9 @@ struct bq27200_device_info {
 	struct i2c_client	*client;
 };
 
+#define to_bq27200_device_info(x) container_of((x), \
+				struct bq27200_device_info, bat);
+
 static enum power_supply_property bq27200_props[] = {
 	POWER_SUPPLY_PROP_PRESENT,
 	POWER_SUPPLY_PROP_VOLTAGE_NOW,
@@ -134,6 +137,7 @@ static int bq27200_current(struct bq27200_device_info *di)
 		dev_dbg(di->dev, "negative current!\n");
 		return -curr;
 	}
+
 	return curr;
 }
 
@@ -155,9 +159,6 @@ static int bq27200_rsoc(struct bq27200_device_info *di)
 	return rsoc >> 8;
 }
 
-#define to_bq27200_device_info(x) container_of((x), \
-				struct bq27200_device_info, bat);
-
 static int bq27200_get_property(struct power_supply *psy,
 					enum power_supply_property psp,
 					union power_supply_propval *val)
@@ -196,10 +197,6 @@ static void bq27200_powersupply_init(struct bq27200_device_info *di)
 	di->bat.external_power_changed = NULL;
 }
 
-/*
- * BQ27200 specific code
- */
-
 static int _bq27200_read(u8 reg, int *rt_value, int b_single,
 			struct bq27200_device_info *di)
 {
@@ -236,6 +233,7 @@ static int _bq27200_read(u8 reg, int *rt_value, int b_single,
 			return 0;
 		}
 	}
+
 	return err;
 }
 
@@ -264,7 +262,7 @@ static int bq27200_battery_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, di);
 	di->dev = &client->dev;
 	di->bat.name = client->name;
-	bus->read = &_bq27200_read;
+	bus->read = _bq27200_read;
 	di->bus = bus;
 	di->client = client;
 
@@ -276,8 +274,6 @@ static int bq27200_battery_probe(struct i2c_client *client,
 		goto batt_failed_3;
 	}
 
-	dev_info(&client->dev, "support ver. %s enabled\n", DRIVER_VERSION);
-
 	return 0;
 
 batt_failed_3:
@@ -301,33 +297,23 @@ static int bq27200_battery_remove(struct i2c_client *client)
 	return 0;
 }
 
-/*
- * Module stuff
- */
-
 static const struct i2c_device_id bq27200_id[] = {
 	{ "bq27200", 0 },
 	{},
 };
 
 static struct i2c_driver bq27200_battery_driver = {
-	.driver = {
-		.name = "bq27200",
+	.driver		= {
+		.name	= "bq27200",
 	},
-	.probe = bq27200_battery_probe,
-	.remove = bq27200_battery_remove,
-	.id_table = bq27200_id,
+	.probe		= bq27200_battery_probe,
+	.remove		= bq27200_battery_remove,
+	.id_table	= bq27200_id,
 };
 
 static int __init bq27200_init(void)
 {
-	int ret;
-
-	ret = i2c_add_driver(&bq27200_battery_driver);
-	if (ret)
-		printk(KERN_ERR "Unable to register BQ27200 driver\n");
-
-	return ret;
+	return i2c_add_driver(&bq27200_battery_driver);
 }
 module_init(bq27200_init);
 
-- 
1.6.1.3


  reply	other threads:[~2009-07-12 18:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-12 18:09 [rfc/patch 01/15] power: bq27x00: rename to bq27200.c Felipe Balbi
2009-07-12 18:09 ` [rfc/patch 02/15] power: bq27200: this is an i2c device Felipe Balbi
2009-07-12 18:09   ` Felipe Balbi [this message]
2009-07-12 18:09     ` [rfc/patch 04/15] power: bq27200: simplify read by using smbus Felipe Balbi
2009-07-12 18:09       ` [rfc/patch 05/15] power: bq27200: remove unnecessary function Felipe Balbi
2009-07-12 18:09         ` [rfc/patch 06/15] power: bq27200: rename structure to something smaller Felipe Balbi
2009-07-12 18:09           ` [rfc/patch 07/15] power: bq27200: add missing suplicants Felipe Balbi
2009-07-12 18:09             ` [rfc/patch 08/15] power: bq27200: define all register space Felipe Balbi
2009-07-12 18:09               ` [rfc/patch 09/15] power: bq27200: fix up current reporting Felipe Balbi
2009-07-12 18:09                 ` [rfc/patch 10/15] power: bq27200: voltage should be expressed in uV Felipe Balbi
2009-07-12 18:09                   ` [rfc/patch 11/15] power: bq27200: temperature in tenths of degrees Felipe Balbi
2009-07-12 18:09                     ` [rfc/patch 12/15] power: bq27200: add power property Felipe Balbi
2009-07-12 18:09                       ` [rfc/patch 13/15] power: bq27200: RSOC is 8-bit wide Felipe Balbi
2009-07-12 18:09                         ` [rfc/patch 14/15] power: bq27200: add time to empty/full Felipe Balbi
2009-07-12 18:09                           ` [rfc/patch 15/15] power: bq27200: add energy average Felipe Balbi
2009-07-12 20:12                           ` [rfc/patch 14/15] power: bq27200: add time to empty/full Felipe Balbi
2009-07-12 20:11                       ` [rfc/patch 12/15] power: bq27200: add power property Felipe Balbi
2009-07-12 18:47   ` [rfc/patch 02/15] power: bq27200: this is an i2c device Linus Walleij
2009-07-12 19:49     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247422177-7329-3-git-send-email-me@felipebalbi.com \
    --to=me@felipebalbi.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®