mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: gregkh@suse.de
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jason Wessel <jason.wessel@windriver.com>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Yinghai Lu <yinghai@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 02/10] usb,early_printk: insert cr prior to nl as needed
Date: Fri, 31 Jul 2009 10:07:05 -0500	[thread overview]
Message-ID: <1249052833-9655-3-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1249052833-9655-2-git-send-email-jason.wessel@windriver.com>

The rs232 drivers send a carriage return prior to a new line in the
early printk code.

The usb debug driver should do the same because you want to be able to
use the same terminal programs and tools for analysis of early printk
data.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Greg KH <gregkh@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
---
 drivers/usb/early/ehci-dbgp.c |   22 ++++++++++++++++------
 1 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
index c7aa0aa..51ec414 100644
--- a/drivers/usb/early/ehci-dbgp.c
+++ b/drivers/usb/early/ehci-dbgp.c
@@ -700,17 +700,27 @@ int __init early_dbgp_init(char *s)
 static void early_dbgp_write(struct console *con, const char *str, u32 n)
 {
 	int chunk, ret;
+	char buf[DBGP_MAX_PACKET];
+	int use_cr = 0;
 
 	if (!ehci_debug)
 		return;
 	while (n > 0) {
-		chunk = n;
-		if (chunk > DBGP_MAX_PACKET)
-			chunk = DBGP_MAX_PACKET;
+		for (chunk = 0; chunk < DBGP_MAX_PACKET && n > 0;
+		     str++, chunk++, n--) {
+			if (!use_cr && *str == '\n') {
+				use_cr = 1;
+				buf[chunk] = '\r';
+				str--;
+				n++;
+				continue;
+			}
+			if (use_cr)
+				use_cr = 0;
+			buf[chunk] = *str;
+		}
 		ret = dbgp_bulk_write(USB_DEBUG_DEVNUM,
-			dbgp_endpoint_out, str, chunk);
-		str += chunk;
-		n -= chunk;
+			dbgp_endpoint_out, buf, chunk);
 	}
 }
 
-- 
1.6.0.3.523.g304d0


  reply	other threads:[~2009-07-31 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 15:07 [PATCH 0/10] x86: EHCI and earlyprintk= improvements (Round 2) Jason Wessel
2009-07-31 15:07 ` [PATCH 01/10] ehci early_printk: split ehci debug driver from early_printk.c Jason Wessel
2009-07-31 15:07   ` Jason Wessel [this message]
2009-07-31 15:07     ` [PATCH 03/10] ehci-dbgp: Execute early BIOS hand off Jason Wessel
2009-07-31 15:07       ` [PATCH 04/10] usb,early_printk: EHCI debug controller initialization delays Jason Wessel
2009-07-31 15:07         ` [PATCH 05/10] printk,early_printk,console: Allow more than one early console Jason Wessel
2009-07-31 15:07           ` [PATCH 06/10] ehci-dbgp: stability improvements and external re-init Jason Wessel
2009-07-31 15:07             ` [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device Jason Wessel
2009-07-31 15:07               ` [PATCH 08/10] ehci-dbgp: errata for EHCI debug controller initialization Jason Wessel
2009-07-31 15:07                 ` [PATCH 09/10] ehci-dbgp: errata for EHCI debug/host controller synchronization Jason Wessel
2009-07-31 15:07                   ` [PATCH 10/10] ehci-dbgp,documentation: Documentation updates for ehci-dbgp Jason Wessel
2009-07-31 15:41               ` [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device Alan Stern
2009-07-31 17:22                 ` Jason Wessel
2009-07-31 18:53                   ` Alan Stern
     [not found]                     ` <4A7355EA.60107@windriver.com>
2009-07-31 21:34                       ` Jason Wessel
2009-08-01 15:47                         ` Alan Stern
2009-08-03 14:48                           ` Jason Wessel
2009-08-18 17:47               ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2009-07-20 20:06 [PATCH 0/10] x86: EHCI and earlyprintk= improvements Jason Wessel
2009-07-20 20:06 ` [PATCH 01/10] ehci early_printk: split ehci debug driver from early_printk.c Jason Wessel
2009-07-20 20:06   ` [PATCH 02/10] usb,early_printk: insert cr prior to nl as needed Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249052833-9655-3-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®