mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: gregkh@suse.de
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jason Wessel <jason.wessel@windriver.com>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	dbrownell@users.sourceforge.net, Yinghai Lu <yinghai@kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 03/10] ehci-dbgp: Execute early BIOS hand off
Date: Fri, 31 Jul 2009 10:07:06 -0500	[thread overview]
Message-ID: <1249052833-9655-4-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1249052833-9655-3-git-send-email-jason.wessel@windriver.com>

The PCI quirk code executes a BIOS hand off to obtain full control of
the EHCI host controller, the self contained ehci-dbgp driver must do
the same thing using the early PCI API, else the BIOS can cause a
fatal fault.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Cc: Greg KH <gregkh@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: dbrownell@users.sourceforge.net
Cc: Yinghai Lu <yinghai@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
---
 drivers/usb/early/ehci-dbgp.c |   49 +++++++++++++++++++++++++++++++++++++++++
 1 files changed, 49 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
index 51ec414..f4bfe31 100644
--- a/drivers/usb/early/ehci-dbgp.c
+++ b/drivers/usb/early/ehci-dbgp.c
@@ -435,6 +435,53 @@ static void __init detect_set_debug_port(void)
 	}
 }
 
+/* The code in early_ehci_bios_handoff() is derived from the usb pci
+ * quirk initialization, but altered so as to use the early PCI
+ * routines. */
+#define EHCI_USBLEGSUP_BIOS	(1 << 16)	/* BIOS semaphore */
+#define EHCI_USBLEGCTLSTS	4		/* legacy control/status */
+static void __init early_ehci_bios_handoff(void)
+{
+	u32 hcc_params = readl(&ehci_caps->hcc_params);
+	int offset = (hcc_params >> 8) & 0xff;
+	u32 cap;
+	int msec;
+
+	if (!offset)
+		return;
+
+	cap = read_pci_config(ehci_dev.bus, ehci_dev.slot,
+			      ehci_dev.func, offset);
+	dbgp_printk("dbgp: ehci BIOS state %08x\n", cap);
+
+	if ((cap & 0xff) == 1 && (cap & EHCI_USBLEGSUP_BIOS)) {
+		dbgp_printk("dbgp: BIOS handoff\n");
+		write_pci_config_byte(ehci_dev.bus, ehci_dev.slot,
+				      ehci_dev.func, offset + 3, 1);
+	}
+
+	/* if boot firmware now owns EHCI, spin till it hands it over. */
+	msec = 1000;
+	while ((cap & EHCI_USBLEGSUP_BIOS) && (msec > 0)) {
+		mdelay(10);
+		msec -= 10;
+		cap = read_pci_config(ehci_dev.bus, ehci_dev.slot,
+				      ehci_dev.func, offset);
+	}
+
+	if (cap & EHCI_USBLEGSUP_BIOS) {
+		/* well, possibly buggy BIOS... try to shut it down,
+		 * and hope nothing goes too wrong */
+		dbgp_printk("dbgp: BIOS handoff failed: %08x\n", cap);
+		write_pci_config_byte(ehci_dev.bus, ehci_dev.slot,
+				      ehci_dev.func, offset + 2, 0);
+	}
+
+	/* just in case, always disable EHCI SMIs */
+	write_pci_config_byte(ehci_dev.bus, ehci_dev.slot, ehci_dev.func,
+			      offset + EHCI_USBLEGCTLSTS, 0);
+}
+
 static int __init ehci_setup(void)
 {
 	struct usb_debug_descriptor dbgp_desc;
@@ -446,6 +493,8 @@ static int __init ehci_setup(void)
 	int port_map_tried;
 	int playtimes = 3;
 
+	early_ehci_bios_handoff();
+
 try_next_time:
 	port_map_tried = 0;
 
-- 
1.6.0.3.523.g304d0


  reply	other threads:[~2009-07-31 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 15:07 [PATCH 0/10] x86: EHCI and earlyprintk= improvements (Round 2) Jason Wessel
2009-07-31 15:07 ` [PATCH 01/10] ehci early_printk: split ehci debug driver from early_printk.c Jason Wessel
2009-07-31 15:07   ` [PATCH 02/10] usb,early_printk: insert cr prior to nl as needed Jason Wessel
2009-07-31 15:07     ` Jason Wessel [this message]
2009-07-31 15:07       ` [PATCH 04/10] usb,early_printk: EHCI debug controller initialization delays Jason Wessel
2009-07-31 15:07         ` [PATCH 05/10] printk,early_printk,console: Allow more than one early console Jason Wessel
2009-07-31 15:07           ` [PATCH 06/10] ehci-dbgp: stability improvements and external re-init Jason Wessel
2009-07-31 15:07             ` [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device Jason Wessel
2009-07-31 15:07               ` [PATCH 08/10] ehci-dbgp: errata for EHCI debug controller initialization Jason Wessel
2009-07-31 15:07                 ` [PATCH 09/10] ehci-dbgp: errata for EHCI debug/host controller synchronization Jason Wessel
2009-07-31 15:07                   ` [PATCH 10/10] ehci-dbgp,documentation: Documentation updates for ehci-dbgp Jason Wessel
2009-07-31 15:41               ` [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device Alan Stern
2009-07-31 17:22                 ` Jason Wessel
2009-07-31 18:53                   ` Alan Stern
     [not found]                     ` <4A7355EA.60107@windriver.com>
2009-07-31 21:34                       ` Jason Wessel
2009-08-01 15:47                         ` Alan Stern
2009-08-03 14:48                           ` Jason Wessel
2009-08-18 17:47               ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2009-07-20 20:06 [PATCH 0/10] x86: EHCI and earlyprintk= improvements Jason Wessel
2009-07-20 20:06 ` [PATCH 01/10] ehci early_printk: split ehci debug driver from early_printk.c Jason Wessel
2009-07-20 20:06   ` [PATCH 02/10] usb,early_printk: insert cr prior to nl as needed Jason Wessel
2009-07-20 20:06     ` [PATCH 03/10] ehci-dbgp: Execute early BIOS hand off Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249052833-9655-4-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=akpm@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®