From: Segher Boessenkool <segher@kernel.crashing.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: "Lu, Yinghai" <yinghai.lu@amd.com>,
Peter Stuge <stuge-linuxbios@cdy.org>,
linux-usb-devel@lists.sourceforge.net,
Stefan Reinauer <stepan@coresystems.de>, Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
David Brownell <david-b@pacbell.net>,
linuxbios@linuxbios.org
Subject: Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.
Date: Wed, 6 Dec 2006 16:31:36 +0100 [thread overview]
Message-ID: <124CB3B2-C140-4B0A-96D0-21457B3DC086@kernel.crashing.org> (raw)
In-Reply-To: <m13b7t7viq.fsf@ebiederm.dsl.xmission.com>
>> What do you mean by
>> + for (reps = 0; reps >= 0; reps++) {
>> ?
>
> If you will not reps is negative. Roughly it is a loop
> that will timeout eventually if a usb debug cable is not present.
> So since I didn't know how many loop iterations made sense I allowed
> it to loop for 2^31 times or until reps goes negative.
This doesn't work however. Signed overflow in C is undefined,
and GCC actually optimises accordingly (unless -fwrapv is used).
Segher
next prev parent reply other threads:[~2006-12-06 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 23:29 Lu, Yinghai
2006-12-05 23:50 ` Eric W. Biederman
2006-12-06 15:31 ` Segher Boessenkool [this message]
2006-12-06 0:00 Lu, Yinghai
2006-12-06 21:08 Lu, Yinghai
2006-12-07 9:51 ` [LinuxBIOS] " Peter Stuge
2006-12-07 22:06 Lu, Yinghai
2006-12-08 3:48 Lu, Yinghai
2006-12-08 7:14 ` Greg KH
2006-12-08 8:52 ` Yinghai Lu
2006-12-08 7:42 ` Eric W. Biederman
2006-12-08 8:53 ` Yinghai Lu
2006-12-08 9:07 ` Eric W. Biederman
2006-12-13 7:00 ` Yinghai Lu
2006-12-13 7:29 ` Eric W. Biederman
2006-12-13 10:09 ` Yinghai Lu
2006-12-13 10:41 ` Yinghai Lu
2006-12-09 3:16 Lu, Yinghai
2006-12-09 10:54 ` Peter Stuge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=124CB3B2-C140-4B0A-96D0-21457B3DC086@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=ak@suse.de \
--cc=david-b@pacbell.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxbios@linuxbios.org \
--cc=stepan@coresystems.de \
--cc=stuge-linuxbios@cdy.org \
--cc=yinghai.lu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®