mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: "Yinghai Lu" <yinghai.lu@amd.com>
Cc: "Greg KH" <gregkh@suse.de>,
	"Peter Stuge" <stuge-linuxbios@cdy.org>,
	linux-usb-devel@lists.sourceforge.net,
	"Stefan Reinauer" <stepan@coresystems.de>,
	linux-kernel@vger.kernel.org, linuxbios@linuxbios.org,
	"Andi Kleen" <ak@suse.de>, "David Brownell" <david-b@pacbell.net>
Subject: Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.
Date: Wed, 13 Dec 2006 00:29:49 -0700	[thread overview]
Message-ID: <m164cgqmmq.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <86802c440612122300k36e84f96x85ef25ebbf27077d@mail.gmail.com> (Yinghai Lu's message of "Tue, 12 Dec 2006 23:00:25 -0800")

"Yinghai Lu" <yinghai.lu@amd.com> writes:

> On 12/8/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>>
>> Your or I missed a bug fix/enhancement in there somewhere.
>>
>
> I found the problem. the __set_fixmap need to __va, so the entries
> will be referred from PAGE_OFFSET.
>
> solution will be
> 1. move enable_dbgp_console from setup_early_printk, and call it from
> setup_arch after init_memory_mapping.
> 2. or make __set_fixmap can use __pa or pa()+__START_KERNEL_map in
> addtion to _va.

3.  Make __va always work.  I had this in my tree and I guess it didn't get
   into my big rollup patch.

Eric


x86_64: Fix the memory mapping in the early page table

diff --git a/arch/x86_64/kernel/head.S b/arch/x86_64/kernel/head.S
index 1e6f808..2f65469 100644
--- a/arch/x86_64/kernel/head.S
+++ b/arch/x86_64/kernel/head.S
@@ -328,9 +328,9 @@ ENTRY(wakeup_level4_pgt)
        .align PAGE_SIZE
 ENTRY(boot_level4_pgt)
        .quad   phys_level3_ident_pgt | 0x007
-       .fill   255,8,0
+       .fill   257,8,0
        .quad   phys_level3_physmem_pgt | 0x007
-       .fill   254,8,0
+       .fill   252,8,0
        /* (2^48-(2*1024*1024*1024))/(2^39) = 511 */
        .quad   phys_level3_kernel_pgt | 0x007
 



  reply	other threads:[~2006-12-13  7:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08  3:48 Lu, Yinghai
2006-12-08  7:14 ` Greg KH
2006-12-08  8:52   ` Yinghai Lu
2006-12-08  7:42 ` Eric W. Biederman
2006-12-08  8:53   ` Yinghai Lu
2006-12-08  9:07     ` Eric W. Biederman
2006-12-13  7:00       ` Yinghai Lu
2006-12-13  7:29         ` Eric W. Biederman [this message]
2006-12-13 10:09           ` Yinghai Lu
2006-12-13 10:41             ` Yinghai Lu
  -- strict thread matches above, loose matches on Subject: below --
2006-12-09  3:16 Lu, Yinghai
2006-12-09 10:54 ` Peter Stuge
2006-12-07 22:06 Lu, Yinghai
2006-12-06 21:08 Lu, Yinghai
2006-12-07  9:51 ` [LinuxBIOS] " Peter Stuge
2006-12-06  0:00 Lu, Yinghai
2006-12-05 23:29 Lu, Yinghai
2006-12-05 23:50 ` Eric W. Biederman
2006-12-06 15:31   ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m164cgqmmq.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@suse.de \
    --cc=david-b@pacbell.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=linuxbios@linuxbios.org \
    --cc=stepan@coresystems.de \
    --cc=stuge-linuxbios@cdy.org \
    --cc=yinghai.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®