From: David Woodhouse <dwmw2@infradead.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Luming Yu <luming.yu@gmail.com>,
"Luck, Tony" <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC patch] init default dma_ops to prepare intel_iommu_init failure
Date: Wed, 12 Aug 2009 19:20:22 +0100 [thread overview]
Message-ID: <1250101222.29180.139.camel@macbook.infradead.org> (raw)
In-Reply-To: <20090812181722.GA32653@linux-os.sc.intel.com>
On Wed, 2009-08-12 at 11:17 -0700, Fenghua Yu wrote:
>
> > void __init pci_swiotlb_init(void)
> > {
> > - if (!iommu_detected || iommu_pass_through) {
>
> This check can not be removed. Otherwise, swiotlb_dma_ops will always override
> previous dma_ops value.
>
> I think you can change this check to something like:
> if (!dma_ops || iommu_pass_through) {
> With this change, checking iommu_detected is unnecesary because checking dma_ops
> covers it.
Hm, that iommu_pass_through should go away anyway. See commit 19943b0e3.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-08-12 18:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 9:20 Luming Yu
2009-08-12 9:36 ` David Woodhouse
2009-08-12 18:17 ` Fenghua Yu
2009-08-12 18:20 ` David Woodhouse [this message]
2009-08-13 4:49 ` FUJITA Tomonori
2009-08-13 5:48 ` Luming Yu
2009-08-13 6:30 ` FUJITA Tomonori
2009-08-13 6:52 ` FUJITA Tomonori
2009-08-13 7:03 ` Luming Yu
2009-08-13 7:14 ` FUJITA Tomonori
2009-08-13 7:37 ` Luming Yu
2009-08-13 8:03 ` FUJITA Tomonori
2009-08-13 8:11 ` Luming Yu
2009-08-13 8:49 ` David Woodhouse
2009-08-13 9:00 ` FUJITA Tomonori
2009-08-13 9:00 ` Luming Yu
2009-08-13 17:08 ` David Woodhouse
2009-08-13 17:30 ` Yu, Fenghua
2009-08-14 5:44 ` Luming Yu
2009-08-13 2:11 ` FUJITA Tomonori
2009-08-13 2:24 ` Luming Yu
2009-08-13 3:15 ` FUJITA Tomonori
2009-08-13 3:18 ` FUJITA Tomonori
2009-08-13 8:26 ` David Woodhouse
2009-08-13 8:35 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250101222.29180.139.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®