From: Luming Yu <luming.yu@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [RFC patch] init default dma_ops to prepare intel_iommu_init failure
Date: Wed, 12 Aug 2009 17:20:11 +0800 [thread overview]
Message-ID: <3877989d0908120220q5104d2e7rd272ececbc45e377@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]
Hi there,
On ia64 platform with dmar table and new upstream
kernel(config_dmar_default_on enabled),
if intel_iommu_init ends up without dma_ops initialized or other iommu
failures.
We got nothing to fall back. The following patch fixes it.
Please review. If make sense, please apply.
**The patch is enclosed in text attachment*
**Using web client to send the patch* *
**below is for review, please apply attached patch*/
Thanks,
Luming
Signed-off-by: Yu Luming <luming.yu@intel.com>
arch/ia64/kernel/pci-swiotlb.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/arch/ia64/kernel/pci-swiotlb.c b/arch/ia64/kernel/pci-swiotlb.c
index 223abb1..d5dcaf5 100644
--- a/arch/ia64/kernel/pci-swiotlb.c
+++ b/arch/ia64/kernel/pci-swiotlb.c
@@ -46,15 +46,13 @@ void __init swiotlb_dma_init(void)
void __init pci_swiotlb_init(void)
{
- if (!iommu_detected || iommu_pass_through) {
#ifdef CONFIG_IA64_GENERIC
- swiotlb = 1;
- printk(KERN_INFO "PCI-DMA: Re-initialize machine vector.\n");
- machvec_init("dig");
- swiotlb_init();
- dma_ops = &swiotlb_dma_ops;
+ swiotlb = 1;
+ printk(KERN_INFO "PCI-DMA: Re-initialize machine vector.\n");
+ machvec_init("dig");
+ swiotlb_init();
+ dma_ops = &swiotlb_dma_ops;
#else
- panic("Unable to find Intel IOMMU");
+ panic("Unable to find Intel IOMMU");
#endif
- }
}
[-- Attachment #2: 5 --]
[-- Type: application/octet-stream, Size: 758 bytes --]
diff --git a/arch/ia64/kernel/pci-swiotlb.c b/arch/ia64/kernel/pci-swiotlb.c
index 223abb1..d5dcaf5 100644
--- a/arch/ia64/kernel/pci-swiotlb.c
+++ b/arch/ia64/kernel/pci-swiotlb.c
@@ -46,15 +46,13 @@ void __init swiotlb_dma_init(void)
void __init pci_swiotlb_init(void)
{
- if (!iommu_detected || iommu_pass_through) {
#ifdef CONFIG_IA64_GENERIC
- swiotlb = 1;
- printk(KERN_INFO "PCI-DMA: Re-initialize machine vector.\n");
- machvec_init("dig");
- swiotlb_init();
- dma_ops = &swiotlb_dma_ops;
+ swiotlb = 1;
+ printk(KERN_INFO "PCI-DMA: Re-initialize machine vector.\n");
+ machvec_init("dig");
+ swiotlb_init();
+ dma_ops = &swiotlb_dma_ops;
#else
- panic("Unable to find Intel IOMMU");
+ panic("Unable to find Intel IOMMU");
#endif
- }
}
next reply other threads:[~2009-08-12 9:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 9:20 Luming Yu [this message]
2009-08-12 9:36 ` David Woodhouse
2009-08-12 18:17 ` Fenghua Yu
2009-08-12 18:20 ` David Woodhouse
2009-08-13 4:49 ` FUJITA Tomonori
2009-08-13 5:48 ` Luming Yu
2009-08-13 6:30 ` FUJITA Tomonori
2009-08-13 6:52 ` FUJITA Tomonori
2009-08-13 7:03 ` Luming Yu
2009-08-13 7:14 ` FUJITA Tomonori
2009-08-13 7:37 ` Luming Yu
2009-08-13 8:03 ` FUJITA Tomonori
2009-08-13 8:11 ` Luming Yu
2009-08-13 8:49 ` David Woodhouse
2009-08-13 9:00 ` FUJITA Tomonori
2009-08-13 9:00 ` Luming Yu
2009-08-13 17:08 ` David Woodhouse
2009-08-13 17:30 ` Yu, Fenghua
2009-08-14 5:44 ` Luming Yu
2009-08-13 2:11 ` FUJITA Tomonori
2009-08-13 2:24 ` Luming Yu
2009-08-13 3:15 ` FUJITA Tomonori
2009-08-13 3:18 ` FUJITA Tomonori
2009-08-13 8:26 ` David Woodhouse
2009-08-13 8:35 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3877989d0908120220q5104d2e7rd272ececbc45e377@mail.gmail.com \
--to=luming.yu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®