* [PATCH] module: preferred way to use MODULE_AUTHOR
@ 2009-08-28 9:16 Johannes Berg
2009-09-03 11:12 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-08-28 9:16 UTC (permalink / raw)
To: trivial; +Cc: linux-kernel, Luciano Coelho
For the longest time now we've been using multiple
MODULE_AUTHOR() statements when a module has more
than one author, but the comment here disagrees.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
include/linux/module.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- wireless-testing.orig/include/linux/module.h 2009-08-28 11:12:34.000000000 +0200
+++ wireless-testing/include/linux/module.h 2009-08-28 11:13:52.000000000 +0200
@@ -127,7 +127,10 @@ extern struct module __this_module;
*/
#define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
-/* Author, ideally of form NAME[, NAME]*[ and NAME] */
+/*
+ * Author(s), use "Name <email>" or just "Name", for multiple
+ * authors use multiple MODULE_AUTHOR() statements/lines.
+ */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
/* What your module does. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] module: preferred way to use MODULE_AUTHOR
2009-08-28 9:16 [PATCH] module: preferred way to use MODULE_AUTHOR Johannes Berg
@ 2009-09-03 11:12 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2009-09-03 11:12 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-kernel, Luciano Coelho
On Fri, 28 Aug 2009, Johannes Berg wrote:
> For the longest time now we've been using multiple
> MODULE_AUTHOR() statements when a module has more
> than one author, but the comment here disagrees.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> include/linux/module.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- wireless-testing.orig/include/linux/module.h 2009-08-28 11:12:34.000000000 +0200
> +++ wireless-testing/include/linux/module.h 2009-08-28 11:13:52.000000000 +0200
> @@ -127,7 +127,10 @@ extern struct module __this_module;
> */
> #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
>
> -/* Author, ideally of form NAME[, NAME]*[ and NAME] */
> +/*
> + * Author(s), use "Name <email>" or just "Name", for multiple
> + * authors use multiple MODULE_AUTHOR() statements/lines.
> + */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
>
> /* What your module does. */
Applied, thanks Johannes.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-03 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-28 9:16 [PATCH] module: preferred way to use MODULE_AUTHOR Johannes Berg
2009-09-03 11:12 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®