Re: [PATCH 2/6] thermal: sysfs-api.txt - document passive attribute for thermal zones

[Zhang Rui <rui.zhang@intel.com>]

On Thu, 2009-08-27 at 00:17 +0800, Frans Pop wrote:
> Signed-off-by: Frans Pop <elendil@planet.nl>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Sujith Thomas <sujith.thomas@intel.com>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> 
> diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt
> index 895337f..2a036eb 100644
> --- a/Documentation/thermal/sysfs-api.txt
> +++ b/Documentation/thermal/sysfs-api.txt
> @@ -3,7 +3,7 @@ Generic Thermal Sysfs driver How To
>  
>  Written by Sujith Thomas <sujith.thomas@intel.com>, Zhang Rui <rui.zhang@intel.com>
>  
> -Updated: 2 January 2008
> +Updated: 21 August 2009
>  
>  Copyright (c)  2008 Intel Corporation
>  
> @@ -199,6 +199,15 @@ cdev[0-*]_trip_point
>  	point.
>  	RO, Optional
>  
> +passive
> +	Attribute is only present for zones which do not have a passive
> +	cooling policy (_PSV) defined in ACPI.

We should not involve any platform specific stuff in this documentation.
how about "Attribute is only present for zones in which the passive
cooling policy is not supported by native thermal driver"

>  Default is zero and can be
> +	set to a temperature (in millidegrees) to enable a passive trip
> +	point for the zone. Activation is done by polling with an interval
> +	of 1 second.
> +	Unit: millidegrees Celsius
> +	RW, Optional
> +
>  *****************************
>  * Cooling device attributes *
>  *****************************
> @@ -230,8 +239,9 @@ thermal_zone_device (thermal_zone1) with 4 trip points in all.
>  It has one processor and one fan, which are both registered as
>  thermal_cooling_device.
>  
> -If the processor is listed in _PSL method, and the fan is listed in _AL0
> -method, the sys I/F structure will be built like this:
> +If the processor is listed in _PSL method, the fan is listed in _AL0
> +method, and the zone has a _PSV method, the sys I/F structure will be
> +built like this:
>  
For an ACPI thermal zone, supporting passive cooling means that both
_PSL and _PSV are available.
so I don't think we need to change this. :)

thanks,
rui
>  /sys/class/thermal:
>